From 11711f217c5b0c1b44ca360dd8c5b5d2ebfecf44 Mon Sep 17 00:00:00 2001 From: hj kim Date: Tue, 15 Sep 2020 16:48:44 +0900 Subject: [PATCH] Fix resource leak Change-Id: I0bfc4257fa11566103d0b4d8068ee986779f2890 --- packaging/capi-media-controller.spec | 2 +- src/media_controller_client.c | 8 ++++---- src/media_controller_server.c | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packaging/capi-media-controller.spec b/packaging/capi-media-controller.spec index 2d314ad..1a0470a 100644 --- a/packaging/capi-media-controller.spec +++ b/packaging/capi-media-controller.spec @@ -1,6 +1,6 @@ Name: capi-media-controller Summary: A media controller library in Tizen Native API -Version: 0.2.18 +Version: 0.2.19 Release: 1 Group: Multimedia/API License: Apache-2.0 diff --git a/src/media_controller_client.c b/src/media_controller_client.c index e24d67b..438a01a 100644 --- a/src/media_controller_client.c +++ b/src/media_controller_client.c @@ -217,11 +217,11 @@ static void __client_cmd_reply_received_cb(const char *interface_name, const cha params = g_strsplit(message, MC_STRING_DELIMITER, 0); mc_retm_if_failed(params); - if (params[1] != NULL) - mc_retm_if(MEDIA_CONTROLLER_ERROR_NONE != mc_safe_strtoi(params[1], &result_code), "getting result_code is failed"); + if (mc_safe_strtoi(params[1], &result_code) != MEDIA_CONTROLLER_ERROR_NONE) + mc_error("getting result_code is failed"); - if (params[2] != NULL) - mc_retm_if(MEDIA_CONTROLLER_ERROR_NONE != mc_safe_strtoi(params[2], &enc_size), "getting message is failed"); + if(mc_safe_strtoi(params[2], &enc_size) != MEDIA_CONTROLLER_ERROR_NONE) + mc_error("getting enc_size is failed"); if (enc_size > 0) bundle_data = bundle_decode((bundle_raw *)params[3], enc_size); diff --git a/src/media_controller_server.c b/src/media_controller_server.c index d6840cc..060f6ab 100644 --- a/src/media_controller_server.c +++ b/src/media_controller_server.c @@ -379,11 +379,11 @@ static void __server_event_reply_received_cb(const char *interface_name, const c params = g_strsplit(message, MC_STRING_DELIMITER, 0); mc_retm_if_failed(params); - if (params[1] != NULL) - mc_retm_if(MEDIA_CONTROLLER_ERROR_NONE != mc_safe_strtoi(params[1], &result_code), "getting result_code is failed"); + if (mc_safe_strtoi(params[1], &result_code) != MEDIA_CONTROLLER_ERROR_NONE) + mc_error("getting result_code is failed"); - if (params[2] != NULL) - mc_retm_if(MEDIA_CONTROLLER_ERROR_NONE != mc_safe_strtoi(params[2], &enc_size), "getting message is failed"); + if (mc_safe_strtoi(params[2], &enc_size) != MEDIA_CONTROLLER_ERROR_NONE) + mc_error("getting enc_size is failed"); if (enc_size > 0) bundle_data = bundle_decode((bundle_raw *)params[3], enc_size); -- 2.7.4