From 651d67b2c2cb5f51738cbdbc25409299e139c0f1 Mon Sep 17 00:00:00 2001 From: "chleun.moon" Date: Thu, 4 May 2017 15:23:33 +0900 Subject: [PATCH] Fix svace issues (WGID-207858, 208122, 208137, 208138) Change-Id: I31373fbb6ad79517e63f4023c1f4bac2f63424e5 Signed-off-by: cheoleun --- src/inet.c | 5 ++++- vpn/plugins/ipsec.c | 6 +++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/inet.c b/src/inet.c index 45408ce..c65ebb3 100755 --- a/src/inet.c +++ b/src/inet.c @@ -1468,6 +1468,9 @@ static int ndisc_send_unspec(int type, int oif, const struct in6_addr *dest, char cbuf[CMSG_SPACE(sizeof(*pinfo))]; struct iovec iov[2]; int fd, datalen, ret, iovlen = 1; +#if defined TIZEN_EXT + char ebuf[256]; +#endif DBG(""); @@ -1547,7 +1550,7 @@ static int ndisc_send_unspec(int type, int oif, const struct in6_addr *dest, ret = sendmsg(fd, &msgh, 0); #if defined TIZEN_EXT - DBG("sendmsg errno: %d/%s", errno, strerror(errno)); + DBG("sendmsg errno: %d/%s", errno, strerror_r(errno, ebuf, sizeof(ebuf))); #endif close(fd); diff --git a/vpn/plugins/ipsec.c b/vpn/plugins/ipsec.c index e4bbf2b..cd8b625 100644 --- a/vpn/plugins/ipsec.c +++ b/vpn/plugins/ipsec.c @@ -722,7 +722,7 @@ static char *load_file_from_path(const char *path) size_t file_size = 0; char *file_buff = NULL; - if (path) { + if (!path) { connman_error("File path is NULL\n"); return NULL; } @@ -841,6 +841,7 @@ static int ipsec_load_cert(struct vpn_provider *provider) DBG("CertType: %s, CertFalg: %s,CertData: %s", type, flag, data); if (!type || ! flag || !data) { connman_error("invalid certification information"); + g_free(data); return -EINVAL; } @@ -971,6 +972,9 @@ done: if(err != 0 && cb) cb(provider, data->user_data, -err); + if (data) + g_free(data); + return; } -- 2.7.4