From d87e2b311e862b5aaf3490e42efd3a6f67d839b4 Mon Sep 17 00:00:00 2001 From: Jeongmo Yang Date: Wed, 28 Aug 2019 16:17:20 +0900 Subject: [PATCH] Fix coverity issue - Unchecked return value [Version] 0.10.185 [Profile] Common [Issue Type] Coverity Change-Id: I19478dc28216d1fa903223df25cda0dea0ce3582 Signed-off-by: Jeongmo Yang --- packaging/libmm-camcorder.spec | 2 +- src/mm_camcorder_internal.c | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packaging/libmm-camcorder.spec b/packaging/libmm-camcorder.spec index 54de2d5..0e347cb 100644 --- a/packaging/libmm-camcorder.spec +++ b/packaging/libmm-camcorder.spec @@ -1,6 +1,6 @@ Name: libmm-camcorder Summary: Camera and recorder library -Version: 0.10.184 +Version: 0.10.185 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_camcorder_internal.c b/src/mm_camcorder_internal.c index ac131e2..0ffdb41 100644 --- a/src/mm_camcorder_internal.c +++ b/src/mm_camcorder_internal.c @@ -427,8 +427,16 @@ static gint __mmcamcorder_init_configure_video_capture(mmf_camcorder_t *hcamcord MMCAM_CAMERA_WIDTH, &resolution_width, MMCAM_CAMERA_HEIGHT, &resolution_height, NULL); + if (ret != MM_ERROR_NONE) { + _mmcam_dbg_err("get attribute[resolution] error"); + return MM_ERROR_CAMCORDER_INTERNAL; + } - mm_camcorder_get_fps_list_by_resolution((MMHandleType)hcamcorder, resolution_width, resolution_height, &fps_info); + ret = mm_camcorder_get_fps_list_by_resolution((MMHandleType)hcamcorder, resolution_width, resolution_height, &fps_info); + if (ret != MM_ERROR_NONE) { + _mmcam_dbg_err("get fps list failed with [%dx%d]", resolution_width, resolution_height); + return MM_ERROR_CAMCORDER_INTERNAL; + } _mmcam_dbg_log("ZeroCopy %d, UserBuffer %d, Videoconvert %d, MPPreviewCb %d", hcamcorder->use_zero_copy_format, hcamcorder->support_user_buffer, -- 2.7.4