From ed7cdefb4cdf7f596f2587a5d09377ac9b18fd38 Mon Sep 17 00:00:00 2001 From: "Myoungwoon Roy, Kim" Date: Wed, 7 Feb 2018 13:50:24 +0900 Subject: [PATCH] ecore_event: Fix a break of consistency of return data Summary: This patch fixes a break of consistency of return data from ecore_event_del. Before EFL 1.20, when calling ecore_event_add(ECORE_EVENT_SIGNAL_USER, event_data, NULL, &data); The user data(data) is saved at event->data. and when user calls ecore_event_del(event_handler), ecore_event_del returns event->data. However, current ecore_event_del returns pd->ev. I think it is ABI break. Test Plan: Execute test suite Reviewers: cedric, raster, stefan_schmidt, Jaehyun_Cho Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5786 Change-Id: Id0ff5dc61cbb18b0ffae378dd7490d4b75e0ed9f --- src/lib/ecore/ecore_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore/ecore_events.c b/src/lib/ecore/ecore_events.c index 7070452..3f9e160 100644 --- a/src/lib/ecore/ecore_events.c +++ b/src/lib/ecore/ecore_events.c @@ -80,7 +80,7 @@ ecore_event_del(Ecore_Event *event) { void *data = NULL; if (!event) return data; - ecore_event_message_data_get((Eo *)event, NULL, &data, NULL, NULL); + ecore_event_message_data_get((Eo *)event, NULL, NULL, NULL, &data); _efl_loop_message_unsend((Eo *)event); return data; } -- 2.7.4