From 21efa01a841ff58f604bd76ffbb84424e61ed49c Mon Sep 17 00:00:00 2001 From: Daniel Hirt Date: Sun, 28 Feb 2016 17:33:40 +0200 Subject: [PATCH] Evas textblock: fix cached markup's stringshare refs The last fix 34020ed131c7a5da4d60bb3a452fac0d9ee5fdd1 was missing a stringshare_del for the NOP case of markup_set. It led to a constantly increasing ref count of the cached markup. @fix Change-Id: Ibd27474c54ed96329b9178c87917963cd4a15c0f --- src/lib/evas/canvas/evas_object_textblock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c index ec1f85f..c5cc28f 100644 --- a/src/lib/evas/canvas/evas_object_textblock.c +++ b/src/lib/evas/canvas/evas_object_textblock.c @@ -6859,6 +6859,7 @@ _evas_textblock_text_markup_set(Eo *eo_obj EINA_UNUSED, Evas_Textblock_Data *o, text = eina_stringshare_add(text); if (text == o->markup_text) { + eina_stringshare_del(text); /* Text is the same, do nothing. */ return; } -- 2.7.4