From 52ddac0afb8337c550ce5068c1c9c5ff785f4ebc Mon Sep 17 00:00:00 2001 From: Seung-Woo Kim Date: Tue, 12 Jan 2021 18:19:36 +0900 Subject: [PATCH] net: rtl88xx: fix to check null adapter UBSAN warns about null pointer accessin rtl88xx. Fix to check null pointer for adapter to remove below warning: UBSAN: Undefined behaviour in drivers/net/wireless/rtl8812au/os_dep/osdep_service.c:1187:2 member access within null pointer of type 'struct _adapter' [...] [] __ubsan_handle_type_mismatch+0x28/0x30 [] rtw_init_timer+0xbc/0xf0 [88XXau] [] devobj_init+0x90/0x100 [88XXau] [] rtw_usb_primary_adapter_init+0x64c/0x1558 [88XXau] [] usb_probe_interface+0x16c/0x4c8 [...] Change-Id: I258df3b790d7b1be49a89706dca46a895c4461b8 Signed-off-by: Seung-Woo Kim --- drivers/net/wireless/rtl8812au/os_dep/osdep_service.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/rtl8812au/os_dep/osdep_service.c b/drivers/net/wireless/rtl8812au/os_dep/osdep_service.c index 7c6d12088f50..36d793d2719e 100644 --- a/drivers/net/wireless/rtl8812au/os_dep/osdep_service.c +++ b/drivers/net/wireless/rtl8812au/os_dep/osdep_service.c @@ -1183,6 +1183,9 @@ void rtw_init_timer(_timer *ptimer, void *padapter, void *pfunc, void *ctx) { _adapter *adapter = (_adapter *)padapter; + if (!adapter) + return; + #ifdef PLATFORM_LINUX _init_timer(ptimer, adapter->pnetdev, pfunc, ctx); #endif -- 2.34.1