From f6a5ddf8bdfbd3d3ac053f9d020294b303453469 Mon Sep 17 00:00:00 2001 From: Sangchul Lee Date: Fri, 13 Jan 2023 12:39:00 +0900 Subject: [PATCH] webrtc_stats: Fix memory leak [Version] 0.3.282 [Issue type] Resource leak Change-Id: Ia4d3a70b80a4eb69b0052dc36f9875b8598dd5d9 Signed-off-by: Sangchul Lee --- packaging/capi-media-webrtc.spec | 2 +- src/webrtc_stats.c | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec index 01c695a4..3d6014bd 100644 --- a/packaging/capi-media-webrtc.spec +++ b/packaging/capi-media-webrtc.spec @@ -1,6 +1,6 @@ Name: capi-media-webrtc Summary: A WebRTC library in Tizen Native API -Version: 0.3.281 +Version: 0.3.282 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/src/webrtc_stats.c b/src/webrtc_stats.c index d8009100..8b9d1f8c 100644 --- a/src/webrtc_stats.c +++ b/src/webrtc_stats.c @@ -468,8 +468,8 @@ static void __stats_codec_invoke_callback(const GstStructure *s, webrtc_stats_ty static void __stats_inbound_rtp_invoke_callback(const GstStructure *s, webrtc_stats_type_e type, stats_field_s **fields_list, promise_userdata_s *user_data) { stats_userdata_s stats_userdata = { .p_userdata = user_data, .type = type, .fields_list = fields_list, .export = true }; - GstStructure *rtpjitterbuffer_stats; - GstStructure *rtpsource_stats; + g_autoptr(GstStructure) rtpjitterbuffer_stats = NULL; + g_autoptr(GstStructure) rtpsource_stats = NULL; RET_IF(user_data == NULL, "user_data is NULL"); @@ -491,14 +491,12 @@ static void __stats_inbound_rtp_invoke_callback(const GstStructure *s, webrtc_st return; LOG_DEBUG("gst-rtpsource-stats ---> "); gst_structure_foreach(rtpsource_stats, __stats_field_foreach_cb, &stats_userdata); - if (user_data->exit) - return; } static void __stats_outbound_rtp_invoke_callback(const GstStructure *s, webrtc_stats_type_e type, stats_field_s **fields_list, promise_userdata_s *user_data) { stats_userdata_s stats_userdata = { .p_userdata = user_data, .type = type, .fields_list = fields_list, .export = true }; - GstStructure *rtpsource_stats; + g_autoptr(GstStructure) rtpsource_stats = NULL; RET_IF(user_data == NULL, "user_data is NULL"); -- 2.34.1