From 2f69ae753aa94a29658d6ca28859dd4cb9b697dd Mon Sep 17 00:00:00 2001 From: Ilho Kim Date: Thu, 22 Sep 2022 14:13:39 +0900 Subject: [PATCH] Fix static analysis issue - Null pointer dereference Change-Id: Ie3dda3872cf472d9c3a76a4b1f7738d6725bb5c6 Signed-off-by: Ilho Kim --- src/hybrid/step/pkgmgr/step_merge_xml.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/hybrid/step/pkgmgr/step_merge_xml.cc b/src/hybrid/step/pkgmgr/step_merge_xml.cc index 8b6fbb3..4a3cd7d 100644 --- a/src/hybrid/step/pkgmgr/step_merge_xml.cc +++ b/src/hybrid/step/pkgmgr/step_merge_xml.cc @@ -98,6 +98,10 @@ xmlNodePtr StepMergeXml::GetXmlNode(const xmlDocPtr doc, void StepMergeXml::MergeXmlNode(xmlNodePtr node1, xmlNodePtr node2) { xmlNodePtr last = xmlGetLastChild(node1); + if (!last) { + LOG(ERROR) << "Failed to get last child node"; + return; + } xmlNodePtr next; // merge node2's child into node1 for (xmlNodePtr cur = node2->children; cur; cur = next) { -- 2.7.4