From ffa7f7bd5bd8b497ed9378e1217d33601296a932 Mon Sep 17 00:00:00 2001 From: "iposva@chromium.org" Date: Fri, 12 Sep 2008 04:31:34 +0000 Subject: [PATCH] - Update test status file with fixed tests for ARM and add failing test tracked by issue 67. - Remove debugging aid stop("Generate_ArgumentsAdaptorTrampoline - non-function call") - Cleanup comment Review URL: http://codereview.chromium.org/2801 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@290 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/builtins-arm.cc | 2 +- src/top.cc | 3 --- test/mjsunit/mjsunit.status | 6 +++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/builtins-arm.cc b/src/builtins-arm.cc index 425a15519..107629c55 100644 --- a/src/builtins-arm.cc +++ b/src/builtins-arm.cc @@ -644,7 +644,7 @@ void Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) { { Label invoke; __ tst(r1, r1); __ b(ne, &invoke); - __ stop("Generate_ArgumentsAdaptorTrampoline - non-function call"); + //__ stop("Generate_ArgumentsAdaptorTrampoline - non-function call"); __ mov(r2, Operand(0)); // expected arguments is 0 for CALL_NON_FUNCTION __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION); __ b(&enough); diff --git a/src/top.cc b/src/top.cc index 236bdedb9..e9d8b6e5a 100644 --- a/src/top.cc +++ b/src/top.cc @@ -621,9 +621,6 @@ Object* Top::PromoteScheduledException() { } -// TODO(1233523): Get rid of this hackish abstraction once all -// JavaScript frames have a function associated with them. - // NOTE: The stack trace frame iterator is an iterator that only // traverse proper JavaScript frames; that is JavaScript frames that // have proper JavaScript functions. This excludes the problematic diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index 4289bc463..7c3b707fe 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -62,6 +62,6 @@ debug-step-stub-callfunction: FAIL debug-stepin-constructor: FAIL debug-step: FAIL regress/regress-998565: FAIL -regress/regress-1081309: FAIL -# Call as function does not always work on ARM port yet. -number-string-index-call: FAIL + +# Issue 67: ARM fails in: Generate_ArgumentsAdaptorTrampoline - non-function call +call-non-function-call: FAIL -- 2.34.1