From ff7e6a14b0033c7ecd7a2b3b7470ba7a54449c82 Mon Sep 17 00:00:00 2001 From: Stian Selnes Date: Thu, 21 Jan 2016 13:25:40 +0100 Subject: [PATCH] harness: Fix docs for stress test functions notify is not called per buffer, but when the thread is freed. Comment about serialized events and OOB does not make sense for upstream events. https://bugzilla.gnome.org/show_bug.cgi?id=761909 --- libs/gst/check/gstharness.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libs/gst/check/gstharness.c b/libs/gst/check/gstharness.c index 979d423..b878b2b 100644 --- a/libs/gst/check/gstharness.c +++ b/libs/gst/check/gstharness.c @@ -2936,12 +2936,11 @@ gst_harness_stress_push_buffer_start_full (GstHarness * h, * @func: a #GstHarnessPrepareBufferFunc function called before every iteration * to prepare / create a #GstBuffer for pushing * @data: a #gpointer with data to the #GstHarnessPrepareBufferFunc function - * @notify: a #GDestroyNotify that is called for every push to allow cleaning - * up the #GstBuffer. (like gst_buffer_unref) + * @notify: a #GDestroyNotify that is called when thread is stopped * @sleep: a #gulong specifying how long to sleep in (microseconds) for * each call to gst_pad_push * - * Push a #GstBuffer in intervals of @sleep microseconds. + * Push a #GstBuffer returned by @func in intervals of @sleep microseconds. * * MT safe. * @@ -3007,9 +3006,6 @@ gst_harness_stress_push_event_start_full (GstHarness * h, * * Push the @event onto the harnessed #GstElement srcpad in intervals of * @sleep microseconds. - * Pushing events should generally be OOB events. - * If you need serialized events, you may use a custom stress thread which - * both pushes buffers and events. * * MT safe. * -- 2.7.4