From ff6fa24786eb2c03c1af95e2559fa3fd0b2f3893 Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Thu, 9 Feb 2017 15:35:33 +0000 Subject: [PATCH] Fix NULL pointer dereference This commit fixes a segmentation fault on tab completion when certain debuginfo is installed: https://bugzilla.redhat.com/show_bug.cgi?id=1398387 gdb/ChangeLog: * symtab.c (add_symtab_completions): Prevent NULL pointer dereference. --- gdb/ChangeLog | 5 +++++ gdb/symtab.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2792509..318dbaf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-02-09 Gary Benson + + * symtab.c (add_symtab_completions): Prevent NULL pointer + dereference. + 2017-02-08 Pedro Alves * interps.c (interp::interp): Remove reference to quiet_p. diff --git a/gdb/symtab.c b/gdb/symtab.c index 356f480..2c141e5 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -5163,6 +5163,9 @@ add_symtab_completions (struct compunit_symtab *cust, struct block_iterator iter; int i; + if (cust == NULL) + return; + for (i = GLOBAL_BLOCK; i <= STATIC_BLOCK; i++) { QUIT; -- 2.7.4