From fef7e1a755d84cf4cb42e41e2f0510c223b1f91a Mon Sep 17 00:00:00 2001 From: ziga-lunarg Date: Mon, 29 Aug 2022 02:16:31 +0200 Subject: [PATCH] Add missing buffer features check in image store tests Check if format supports storage write for VkBufferView where OpTypeImage is Unknown Components: Vulkan VK-GL-CTS issue: 3765 Affected tests: dEQP-VK.image.store.without_format.* Change-Id: I74365f2f753fb61397d83403098a288cdcf53953 --- .../vulkancts/modules/vulkan/image/vktImageLoadStoreTests.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/external/vulkancts/modules/vulkan/image/vktImageLoadStoreTests.cpp b/external/vulkancts/modules/vulkan/image/vktImageLoadStoreTests.cpp index f6f844d19..af0661cf5 100644 --- a/external/vulkancts/modules/vulkan/image/vktImageLoadStoreTests.cpp +++ b/external/vulkancts/modules/vulkan/image/vktImageLoadStoreTests.cpp @@ -486,6 +486,9 @@ void StoreTest::checkSupport (Context& context) const { const VkFormatProperties3KHR formatProperties (context.getFormatProperties(m_format)); + if (!m_declareImageFormatInShader && !(formatProperties.bufferFeatures & VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT_KHR)) + TCU_THROW(NotSupportedError, "Format not supported for unformatted stores via storage buffer"); + if (!m_declareImageFormatInShader && !(formatProperties.optimalTilingFeatures & VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT_KHR)) TCU_THROW(NotSupportedError, "Format not supported for unformatted stores via storage images"); -- 2.34.1