From fee7d21ae7f58badd9bddb28fff34ca291e3c9e8 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Tue, 22 Jan 2013 18:05:59 +0000 Subject: [PATCH] X86: Make sure we account for the FMA4 register immediate value, otherwise rip-rel relocations will be off by one byte. PR15040. llvm-svn: 173176 --- llvm/lib/Target/X86/X86InstrFormats.td | 2 +- llvm/test/MC/X86/x86_64-fma4-encoding.s | 61 +++++++++++++++++++++++++ 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/llvm/lib/Target/X86/X86InstrFormats.td b/llvm/lib/Target/X86/X86InstrFormats.td index 6151d5cce275..44e574d24656 100644 --- a/llvm/lib/Target/X86/X86InstrFormats.td +++ b/llvm/lib/Target/X86/X86InstrFormats.td @@ -570,7 +570,7 @@ class FMA3 o, Format F, dag outs, dag ins, string asm, // FMA4 Instruction Templates class FMA4 o, Format F, dag outs, dag ins, string asm, listpattern, InstrItinClass itin = IIC_DEFAULT> - : I, TA, + : Ii8, TA, OpSize, VEX_4V, VEX_I8IMM, Requires<[HasFMA4]>; // XOP 2, 3 and 4 Operand Instruction Template diff --git a/llvm/test/MC/X86/x86_64-fma4-encoding.s b/llvm/test/MC/X86/x86_64-fma4-encoding.s index 805fc23cf4cf..f7ee351ab514 100644 --- a/llvm/test/MC/X86/x86_64-fma4-encoding.s +++ b/llvm/test/MC/X86/x86_64-fma4-encoding.s @@ -73,6 +73,67 @@ // CHECK: encoding: [0xc4,0xe3,0xfd,0x69,0xc2,0x10] vfmaddpd %ymm2, %ymm1, %ymm0, %ymm0 +// PR15040 +// CHECK: vfmaddss foo(%rip), %xmm1, %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0xf9,0x6a,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddss foo(%rip), %xmm1, %xmm0, %xmm0 + +// CHECK: vfmaddss %xmm1, foo(%rip), %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0x79,0x6a,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddss %xmm1, foo(%rip),%xmm0, %xmm0 + +// CHECK: vfmaddsd foo(%rip), %xmm1, %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0xf9,0x6b,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddsd foo(%rip), %xmm1, %xmm0, %xmm0 + +// CHECK: vfmaddsd %xmm1, foo(%rip), %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0x79,0x6b,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddsd %xmm1, foo(%rip),%xmm0, %xmm0 + +// CHECK: vfmaddps foo(%rip), %xmm1, %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0xf9,0x68,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddps foo(%rip), %xmm1, %xmm0, %xmm0 + +// CHECK: vfmaddps %xmm1, foo(%rip), %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0x79,0x68,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddps %xmm1, foo(%rip),%xmm0, %xmm0 + +// CHECK: vfmaddpd foo(%rip), %xmm1, %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0xf9,0x69,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddpd foo(%rip), %xmm1, %xmm0, %xmm0 + +// CHECK: vfmaddpd %xmm1, foo(%rip), %xmm0, %xmm0 +// CHECK: encoding: [0xc4,0xe3,0x79,0x69,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddpd %xmm1, foo(%rip),%xmm0, %xmm0 + +// CHECK: vfmaddps foo(%rip), %ymm1, %ymm0, %ymm0 +// CHECK: encoding: [0xc4,0xe3,0xfd,0x68,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddps foo(%rip), %ymm1, %ymm0, %ymm0 + +// CHECK: vfmaddps %ymm1, foo(%rip), %ymm0, %ymm0 +// CHECK: encoding: [0xc4,0xe3,0x7d,0x68,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddps %ymm1, foo(%rip),%ymm0, %ymm0 + +// CHECK: vfmaddpd foo(%rip), %ymm1, %ymm0, %ymm0 +// CHECK: encoding: [0xc4,0xe3,0xfd,0x69,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddpd foo(%rip), %ymm1, %ymm0, %ymm0 + +// CHECK: vfmaddpd %ymm1, foo(%rip), %ymm0, %ymm0 +// CHECK: encoding: [0xc4,0xe3,0x7d,0x69,0x05,A,A,A,A,0x10] +// CHECK: fixup A - offset: 5, value: foo-5, kind: reloc_riprel_4byte + vfmaddpd %ymm1, foo(%rip),%ymm0, %ymm0 + // vfmsub // CHECK: vfmsubss (%rcx), %xmm1, %xmm0, %xmm0 // CHECK: encoding: [0xc4,0xe3,0xf9,0x6e,0x01,0x10] -- 2.34.1