From fec9fa3fcc2f7db8ca3ca2ac19d1424129ff556d Mon Sep 17 00:00:00 2001 From: raster Date: Fri, 23 Dec 2011 11:40:05 +0000 Subject: [PATCH] disable bugfix for now. leave commented as note. git-svn-id: http://svn.enlightenment.org/svn/e/trunk/ecore@66477 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- src/lib/ecore/ecore.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lib/ecore/ecore.c b/src/lib/ecore/ecore.c index 3430e97..7e0f973 100644 --- a/src/lib/ecore/ecore.c +++ b/src/lib/ecore/ecore.c @@ -217,7 +217,6 @@ shutdown_evil: EAPI int ecore_shutdown(void) { - Ecore_Pipe *p; /* * take a lock here because _ecore_event_shutdown() does callbacks */ @@ -225,15 +224,21 @@ ecore_shutdown(void) if (--_ecore_init_count != 0) goto unlock; - /* this looks horrible - a hack for now, but something to note. as - * we delete the _thread_call pipe a thread COULD be doing - * ecore_pipe_write() or what not to it at the same time - we - * must ensure all possible users of this _thread_call are finished - * and exited before we delete it here */ + /* this looks horrible - a hack for now, but something to note. as + * we delete the _thread_call pipe a thread COULD be doing + * ecore_pipe_write() or what not to it at the same time - we + * must ensure all possible users of this _thread_call are finished + * and exited before we delete it here */ + /* + * ok - this causes other valgrind complaints regarding glib aquiring + * locks internally. so fix bug a or bug b. let's leave the original + * bug in then and leave this as a note for now + Ecore_Pipe *p; p = _thread_call; _thread_call = NULL; ecore_pipe_wait(p, 1, 0.1); ecore_pipe_del(p); + */ eina_lock_free(&_thread_safety); eina_condition_free(&_thread_cond); eina_lock_free(&_thread_mutex); -- 2.7.4