From fea655dcb38b9b9cacfb52ed2da2445c204f8c7e Mon Sep 17 00:00:00 2001 From: Lucas De Marchi Date: Fri, 7 Mar 2014 01:17:10 -0300 Subject: [PATCH] libkmod-elf: Fix check by class in get_modversions() Commit 51c409b ("Cache the offset of crc") unintentinally changed the comparison "if (elf->class & KMOD_ELF_32)" to "if (elf->class == KMOD_ELF_32)". This has been reported by Serge Voilokov : On Raspberry PI elf->class equals KMOD_ELF_32|KMOD_ELF_LSB so valid condition should be (elf->class & KMOD_ELF_32) instead of (elf->class == KMOD_ELF_32). This fixes "modprobe --dump-modversions" failing on 32b systems. --- libkmod/libkmod-elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkmod/libkmod-elf.c b/libkmod/libkmod-elf.c index 1c11a24..53335f3 100644 --- a/libkmod/libkmod-elf.c +++ b/libkmod/libkmod-elf.c @@ -516,7 +516,7 @@ int kmod_elf_get_modversions(const struct kmod_elf *elf, struct kmod_modversion assert_cc(sizeof(struct kmod_modversion64) == sizeof(struct kmod_modversion32)); - if (elf->class == KMOD_ELF_32) + if (elf->class & KMOD_ELF_32) offcrc = sizeof(uint32_t); else offcrc = sizeof(uint64_t); -- 2.7.4