From fe7925373de46cfde4f5eda4b111a167a4212c74 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Mon, 7 Apr 2014 17:33:34 +0100 Subject: [PATCH] queue2: warn if we can't remove our temporary file It's not fatal though, so do not error out. Coverity 1037121 --- plugins/elements/gstqueue2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/elements/gstqueue2.c b/plugins/elements/gstqueue2.c index 5389681..4feaf97 100644 --- a/plugins/elements/gstqueue2.c +++ b/plugins/elements/gstqueue2.c @@ -1523,8 +1523,12 @@ gst_queue2_close_temp_location_file (GstQueue2 * queue) fflush (queue->temp_file); fclose (queue->temp_file); - if (queue->temp_remove) - remove (queue->temp_location); + if (queue->temp_remove) { + if (remove (queue->temp_location) < 0) { + GST_WARNING_OBJECT (queue, "Failed to remove temporary file %s: %s", + queue->temp_location, strerror (errno)); + } + } queue->temp_file = NULL; clean_ranges (queue); -- 2.7.4