From fe71114a7dc6544491d522cc4793e11b534d43ec Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 28 Nov 2012 12:39:37 +0100 Subject: [PATCH] media: unref pipeline in finalize to avoid leaking it --- gst/rtsp-server/rtsp-media.c | 3 ++- gst/rtsp-server/rtsp-media.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/rtsp-server/rtsp-media.c b/gst/rtsp-server/rtsp-media.c index e5abb0e..3fee991 100644 --- a/gst/rtsp-server/rtsp-media.c +++ b/gst/rtsp-server/rtsp-media.c @@ -171,6 +171,8 @@ gst_rtsp_media_finalize (GObject * obj) g_list_free_full (media->dynamic, gst_object_unref); + if (media->pipeline) + gst_object_unref (media->pipeline); if (media->auth) g_object_unref (media->auth); if (media->pool) @@ -666,7 +668,6 @@ gst_rtsp_media_collect_streams (GstRTSPMedia * media) /* create the stream */ gst_rtsp_media_create_stream (media, elem, pad); gst_object_unref (pad); - gst_object_unref (elem); have_elem = TRUE; diff --git a/gst/rtsp-server/rtsp-media.h b/gst/rtsp-server/rtsp-media.h index b848a10..64cda5e 100644 --- a/gst/rtsp-server/rtsp-media.h +++ b/gst/rtsp-server/rtsp-media.h @@ -76,7 +76,7 @@ typedef enum { * @buffer_size: The UDP buffer size * @auth: the authentication service in use * @multicast_group: the multicast group to use - * @element: the data providing element + * @element: the data providing element, owned by @pipeline * @streams: the different #GstRTSPStream provided by @element * @dynamic: list of dynamic elements managed by @element * @status: the status of the media pipeline -- 2.7.4