From fe3cb82364332b9db3b574e9e41de9c27eff470a Mon Sep 17 00:00:00 2001 From: David Fries Date: Wed, 15 Oct 2008 22:04:52 -0700 Subject: [PATCH] W1: w1_family, remove unused variable need_exit Removed the w1_family structure member variable need_exit. It was only being set and never used. Even if it were to be used it is a polling type operation. Signed-off-by: David Fries Signed-off-by: Evgeniy Polyakov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- drivers/w1/w1_family.c | 7 +------ drivers/w1/w1_family.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/w1/w1_family.c b/drivers/w1/w1_family.c index 8c35f9c..4a09904 100644 --- a/drivers/w1/w1_family.c +++ b/drivers/w1/w1_family.c @@ -48,7 +48,6 @@ int w1_register_family(struct w1_family *newf) if (!ret) { atomic_set(&newf->refcnt, 0); - newf->need_exit = 0; list_add_tail(&newf->family_entry, &w1_families); } spin_unlock(&w1_flock); @@ -73,9 +72,6 @@ void w1_unregister_family(struct w1_family *fent) break; } } - - fent->need_exit = 1; - spin_unlock(&w1_flock); /* deatch devices using this family code */ @@ -113,8 +109,7 @@ struct w1_family * w1_family_registered(u8 fid) static void __w1_family_put(struct w1_family *f) { - if (atomic_dec_and_test(&f->refcnt)) - f->need_exit = 1; + atomic_dec(&f->refcnt); } void w1_family_put(struct w1_family *f) diff --git a/drivers/w1/w1_family.h b/drivers/w1/w1_family.h index 296a87e..3053133 100644 --- a/drivers/w1/w1_family.h +++ b/drivers/w1/w1_family.h @@ -53,7 +53,6 @@ struct w1_family struct w1_family_ops *fops; atomic_t refcnt; - u8 need_exit; }; extern spinlock_t w1_flock; -- 2.7.4