From fde606a14ff15df2ccce55f2bb05b6e2dc46e2c7 Mon Sep 17 00:00:00 2001 From: Lukasz Pawelczyk Date: Tue, 31 Mar 2020 17:02:20 +0200 Subject: [PATCH] Fix yaca_memcmp() properly returning INVALID_PARAMETER Change-Id: I6c788d0a28b170b2dd97ee4866b4fd61dba068ca --- src/crypto.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/crypto.c b/src/crypto.c index 10d313c..98e5a19 100644 --- a/src/crypto.c +++ b/src/crypto.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016 Samsung Electronics Co., Ltd All Rights Reserved + * Copyright (c) 2016-2020 Samsung Electronics Co., Ltd All Rights Reserved * * Contact: Krzysztof Jackiewicz * @@ -431,6 +431,9 @@ API int yaca_context_get_output_length(const yaca_context_h ctx, API int yaca_memcmp(const void *first, const void *second, size_t len) { + if (len > 0 && (first == NULL || second == NULL)) + return YACA_ERROR_INVALID_PARAMETER; + if (CRYPTO_memcmp(first, second, len) == 0) return YACA_ERROR_NONE; -- 2.7.4