From fd91f81c857a6d51957944f159c18c070eef81ed Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Mon, 12 Apr 2021 15:09:49 -0400 Subject: [PATCH] [mlir][spirv] Put debug-only variable in LLVM_DEBUG This avoids paying the cost when building in release. Reviewed By: hanchung Differential Revision: https://reviews.llvm.org/D100325 --- .../Dialect/SPIRV/Transforms/SPIRVConversion.cpp | 32 ++++++++++++---------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp index d26299f..9063b5f 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp @@ -42,14 +42,15 @@ static LogicalResult checkExtensionRequirements( if (targetEnv.allows(ors)) continue; - SmallVector extStrings; - for (spirv::Extension ext : ors) - extStrings.push_back(spirv::stringifyExtension(ext)); - - LLVM_DEBUG(llvm::dbgs() - << label << " illegal: requires at least one extension in [" - << llvm::join(extStrings, ", ") - << "] but none allowed in target environment\n"); + LLVM_DEBUG({ + SmallVector extStrings; + for (spirv::Extension ext : ors) + extStrings.push_back(spirv::stringifyExtension(ext)); + + llvm::dbgs() << label << " illegal: requires at least one extension in [" + << llvm::join(extStrings, ", ") + << "] but none allowed in target environment\n"; + }); return failure(); } return success(); @@ -69,14 +70,15 @@ static LogicalResult checkCapabilityRequirements( if (targetEnv.allows(ors)) continue; - SmallVector capStrings; - for (spirv::Capability cap : ors) - capStrings.push_back(spirv::stringifyCapability(cap)); + LLVM_DEBUG({ + SmallVector capStrings; + for (spirv::Capability cap : ors) + capStrings.push_back(spirv::stringifyCapability(cap)); - LLVM_DEBUG(llvm::dbgs() - << label << " illegal: requires at least one capability in [" - << llvm::join(capStrings, ", ") - << "] but none allowed in target environment\n"); + llvm::dbgs() << label << " illegal: requires at least one capability in [" + << llvm::join(capStrings, ", ") + << "] but none allowed in target environment\n"; + }); return failure(); } return success(); -- 2.7.4