From fd184ee2fa5d11a4c1617d91bb8d891c1ef21dc8 Mon Sep 17 00:00:00 2001 From: Tim Caswell Date: Sun, 3 Jan 2010 14:04:35 -0600 Subject: [PATCH] Rename "Dynamic Property" to "Getter/Setter" in sys.inspect. --- lib/sys.js | 6 +++--- test/mjsunit/test-sys.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/sys.js b/lib/sys.js index ee2f2fd..385ad4c 100644 --- a/lib/sys.js +++ b/lib/sys.js @@ -101,13 +101,13 @@ var formatter = function(value, indent, parents) { var child; if (value.__lookupGetter__(x)) { if (value.__lookupSetter__(x)) { - child = "[Dynamic Property]"; + child = "[Getter/Setter]"; } else { - child = "[Dynamic Property Read-only]"; + child = "[Getter]"; } } else { if (value.__lookupSetter__(x)) { - child = "[Dynamic Property Write-only]"; + child = "[Setter]"; } else { child = f(value[x]); } diff --git a/test/mjsunit/test-sys.js b/test/mjsunit/test-sys.js index e8da2b3..005834c 100644 --- a/test/mjsunit/test-sys.js +++ b/test/mjsunit/test-sys.js @@ -26,8 +26,8 @@ assert.equal('{\n "a": {\n "b": 2\n }\n}', inspect({'a': {'b': 2}})); // Dynamic properties assert.equal( - "{\n \"readonly\": [Dynamic Property Read-only],\n \"readwrite\": [Dynamic Property],\n \"writeonly\": [Dynamic Property Write-only]\n}", - inspect({get readonly() {return 1;},get readwrite(){return 2;},set readwrite(value){},set writeonly(val){}}) + "{\n \"readonly\": [Getter],\n \"readwrite\": [Getter/Setter],\n \"writeonly\": [Setter]\n}", + inspect({get readonly(){},get readwrite(){},set readwrite(val){},set writeonly(val){}}) ); var value = {}; @@ -41,6 +41,6 @@ assert.equal('{\n "0": 1,\n "length": 1\n}', inspect(value)); value = [1,2,3]; value.__defineGetter__('growingLength', function () { this.push(true); return this.length; }); assert.equal( - "{\n \"0\": 1,\n \"1\": 2,\n \"2\": 3,\n \"growingLength\": [Dynamic Property Read-only]\n}", + "{\n \"0\": 1,\n \"1\": 2,\n \"2\": 3,\n \"growingLength\": [Getter]\n}", inspect(value) ); \ No newline at end of file -- 2.7.4