From fd13969ef0df98e87c7f32cbb7b9f2963f4480f5 Mon Sep 17 00:00:00 2001 From: svenpanne Date: Wed, 26 Nov 2014 00:15:46 -0800 Subject: [PATCH] Disable ParserSync test for now, it takes waaaaay too long. Running this in x64.release mode on a powerful HP620 takes 4 seconds, this is at least 2 orders of magnitude too slow and leads to tons of false positives on our build bots due to timeouts. As it is, the cost-benefit ratio is far too low. The whole approach needs to be changed: Instead of trying to exhaust some search space in unit tests, this should be turned into a fuzzing test where only a small but random number of things are tested. The exhaustive approach can be done separately, but definitely not in the unit tests. BUG=v8:3707 Review URL: https://codereview.chromium.org/762743002 Cr-Commit-Position: refs/heads/master@{#25510} --- test/cctest/test-parsing.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc index 99965d2..80d3406 100644 --- a/test/cctest/test-parsing.cc +++ b/test/cctest/test-parsing.cc @@ -1509,7 +1509,9 @@ void TestParserSync(const char* source, } -TEST(ParserSync) { +// TODO(marja) This needs to be turned into a fuzzing test, trying all those +// combinations below takes at least 2 orders of magnitude too long. +DISABLED_TEST(ParserSync) { const char* context_data[][2] = { { "", "" }, { "{", "}" }, -- 2.7.4