From fd0024e48e94008915a6b18112efbbd8abc81ed8 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Tue, 5 Apr 2022 16:02:04 -0400 Subject: [PATCH] c++: -Wshadow=compatible-local type vs var [PR100608] The patch for PR92024 changed -Wshadow=compatible-local to warn if either new or old decl was a type, but the rationale only talked about the case where both are types. If only one is, they aren't compatible. PR c++/100608 gcc/cp/ChangeLog: * name-lookup.cc (check_local_shadow): Use -Wshadow=local if exactly one of 'old' and 'decl' is a type. gcc/testsuite/ChangeLog: * g++.dg/warn/Wshadow-compatible-local-3.C: New test. --- gcc/cp/name-lookup.cc | 4 ++++ gcc/testsuite/g++.dg/warn/Wshadow-compatible-local-3.C | 10 ++++++++++ 2 files changed, 14 insertions(+) create mode 100644 gcc/testsuite/g++.dg/warn/Wshadow-compatible-local-3.C diff --git a/gcc/cp/name-lookup.cc b/gcc/cp/name-lookup.cc index c833b84..d16c577 100644 --- a/gcc/cp/name-lookup.cc +++ b/gcc/cp/name-lookup.cc @@ -3249,6 +3249,10 @@ check_local_shadow (tree decl) enum opt_code warning_code; if (warn_shadow) warning_code = OPT_Wshadow; + else if ((TREE_CODE (decl) == TYPE_DECL) + ^ (TREE_CODE (old) == TYPE_DECL)) + /* If exactly one is a type, they aren't compatible. */ + warning_code = OPT_Wshadow_local; else if ((TREE_TYPE (old) && TREE_TYPE (decl) && same_type_p (TREE_TYPE (old), TREE_TYPE (decl))) diff --git a/gcc/testsuite/g++.dg/warn/Wshadow-compatible-local-3.C b/gcc/testsuite/g++.dg/warn/Wshadow-compatible-local-3.C new file mode 100644 index 0000000..0e5ece7 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wshadow-compatible-local-3.C @@ -0,0 +1,10 @@ +// PR c++/100608 +// { dg-do compile { target c++11 } } +// { dg-additional-options "-Wshadow=compatible-local" } + +template class X {}; + +void foo() +{ + auto a = X{}; // no warning, not compatible +} -- 2.7.4