From fc9865c4a76ed3bbec77da34529e01e64006fed3 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 16 Jul 2020 15:41:55 -0400 Subject: [PATCH] [libc++abi] Temporarily disable test on Apple to fix the CI This test has been failing on some SDKs for a long time because we lack a proper way of identifying the SDK version in Lit. Until that is possible, mark the test as unsupported on Apple to restore the CI. --- libcxxabi/test/test_exception_address_alignment.pass.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libcxxabi/test/test_exception_address_alignment.pass.cpp b/libcxxabi/test/test_exception_address_alignment.pass.cpp index 5847f23..92652f4 100644 --- a/libcxxabi/test/test_exception_address_alignment.pass.cpp +++ b/libcxxabi/test/test_exception_address_alignment.pass.cpp @@ -11,11 +11,10 @@ // The header provided in the SDK of older Xcodes used to provide // an incorrectly aligned _Unwind_Exception type. That causes these tests to -// fail with those SDKs. Note that we use the AppleClang version as a cheap -// proxy for the SDK version. -// XFAIL: apple-clang-11 && libcxxabi-has-system-unwinder -// XFAIL: apple-clang-10 && libcxxabi-has-system-unwinder -// XFAIL: apple-clang-9 && libcxxabi-has-system-unwinder +// fail with those SDKs. +// FIXME: We mark the test as unsupported on Apple until we have a Lit feature +// representing the SDK version. +// UNSUPPORTED: darwin // Test that the address of the exception object is properly aligned as required // by the relevant ABI -- 2.7.4