From fc4350cb4396cc7b28f10a697d45269beda03ff5 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Tue, 13 Jun 2023 23:05:09 -0700 Subject: [PATCH] [NFC][RISCV] rename findFirstNonVersionCharacter with findLastNonVersionCharacter Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D152506 --- llvm/lib/Support/RISCVISAInfo.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Support/RISCVISAInfo.cpp b/llvm/lib/Support/RISCVISAInfo.cpp index 5bb393b..0c564ac 100644 --- a/llvm/lib/Support/RISCVISAInfo.cpp +++ b/llvm/lib/Support/RISCVISAInfo.cpp @@ -176,14 +176,14 @@ static bool stripExperimentalPrefix(StringRef &Ext) { return Ext.consume_front("experimental-"); } -// This function finds the first character that doesn't belong to a version +// This function finds the last character that doesn't belong to a version // (e.g. zba1p0 is extension 'zba' of version '1p0'). So the function will // consume [0-9]*p[0-9]* starting from the backward. An extension name will not // end with a digit or the letter 'p', so this function will parse correctly. // NOTE: This function is NOT able to take empty strings or strings that only // have version numbers and no extension name. It assumes the extension name // will be at least more than one character. -static size_t findFirstNonVersionCharacter(StringRef Ext) { +static size_t findLastNonVersionCharacter(StringRef Ext) { assert(!Ext.empty() && "Already guarded by if-statement in ::parseArchString"); @@ -791,7 +791,7 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension, StringRef Type = getExtensionType(Ext); StringRef Desc = getExtensionTypeDesc(Ext); - auto Pos = findFirstNonVersionCharacter(Ext) + 1; + auto Pos = findLastNonVersionCharacter(Ext) + 1; StringRef Name(Ext.substr(0, Pos)); StringRef Vers(Ext.substr(Pos)); -- 2.7.4