From fc3341b4b55f46ad0846a22ae149d94bac6ce40b Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Fri, 22 Oct 2021 17:48:40 +0200 Subject: [PATCH] platform/x86: system76_acpi: fix Kconfig dependencies When CONFIG_INPUT is disabled, this driver now fails to link: ld.lld: error: undefined symbol: devm_input_allocate_device >>> referenced by system76_acpi.c >>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a ld.lld: error: undefined symbol: input_set_capability >>> referenced by system76_acpi.c >>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a ld.lld: error: undefined symbol: devm_hwmon_device_register_with_info >>> referenced by system76_acpi.c >>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a ld.lld: error: undefined symbol: battery_hook_unregister >>> referenced by system76_acpi.c >>> platform/x86/system76_acpi.o:(system76_remove) in archive drivers/built-in.a Add Kconfig dependencies for each of these three. Fixes: 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models") Fixes: 95563d45b5da ("platform/x86: system76_acpi: Report temperature and fan speed") Fixes: 76f7eba3e0a2 ("platform/x86: system76_acpi: Add battery charging thresholds") Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20211022154901.904984-1-arnd@kernel.org Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede --- drivers/platform/x86/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 9fd0c15..d4c079f 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -931,6 +931,9 @@ config SONYPI_COMPAT config SYSTEM76_ACPI tristate "System76 ACPI Driver" depends on ACPI + depends on ACPI_BATTERY + depends on HWMON + depends on INPUT select NEW_LEDS select LEDS_CLASS select LEDS_TRIGGERS -- 2.7.4