From fbe726c3da9bb8e46291c1186a11e53866f14a9e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Philip=20J=C3=A4genstedt?= Date: Fri, 20 Nov 2009 10:07:43 +0100 Subject: [PATCH] directsoundsink: 16-bit audio is signed, 8-bit is unsigned. Pretending to handle 8-bit signed causes distorted audio when actually given such audio, which you will get if passing 8-bit unsigned through audioconvert ! audioresample, as audioresample only handles 8-bit signed. Fixes #605834. Signed-off-by: David Schleef --- sys/directsound/gstdirectsoundsink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/directsound/gstdirectsoundsink.c b/sys/directsound/gstdirectsoundsink.c index 4eef182..4dba4b3 100644 --- a/sys/directsound/gstdirectsoundsink.c +++ b/sys/directsound/gstdirectsoundsink.c @@ -99,12 +99,12 @@ static GstStaticPadTemplate directsoundsink_sink_factory = GST_PAD_SINK, GST_PAD_ALWAYS, GST_STATIC_CAPS ("audio/x-raw-int, " - "signed = (boolean) { TRUE, FALSE }, " + "signed = (boolean) TRUE, " "width = (int) 16, " "depth = (int) 16, " "rate = (int) [ 1, MAX ], " "channels = (int) [ 1, 2 ]; " "audio/x-raw-int, " - "signed = (boolean) { TRUE, FALSE }, " + "signed = (boolean) FALSE, " "width = (int) 8, " "depth = (int) 8, " "rate = (int) [ 1, MAX ], " "channels = (int) [ 1, 2 ];" -- 2.7.4