From fbdf05a16ec647358e65582721c4ca7dae15e58d Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 24 Apr 2019 16:24:05 -0600 Subject: [PATCH] Change arc_tdesc_init to return bool This changes arc_tdesc_init to return bool. gdb/ChangeLog 2019-05-04 Tom Tromey * arc-tdep.c (arc_tdesc_init): Return bool. --- gdb/ChangeLog | 4 ++++ gdb/arc-tdep.c | 18 +++++++++--------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 18d0ce8..ce7c49b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2019-05-04 Tom Tromey + * arc-tdep.c (arc_tdesc_init): Return bool. + +2019-05-04 Tom Tromey + * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint): Use gdb_assert_not_reached. diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c index 9c02960..108b671 100644 --- a/gdb/arc-tdep.c +++ b/gdb/arc-tdep.c @@ -1720,7 +1720,7 @@ static const struct frame_base arc_normal_base = { Returns TRUE if input tdesc was valid and in this case it will assign TDESC and TDESC_DATA output parameters. */ -static int +static bool arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, struct tdesc_arch_data **tdesc_data) { @@ -1803,7 +1803,7 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, { arc_print (_("Error: ARC v2 target description supplied for " "non-ARCv2 target.\n")); - return FALSE; + return false; } is_reduced_rf = false; @@ -1819,7 +1819,7 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, { arc_print (_("Error: ARC v2 target description supplied for " "non-ARCv2 target.\n")); - return FALSE; + return false; } is_reduced_rf = true; @@ -1836,7 +1836,7 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, { arc_print (_("Error: ARCompact target description supplied " "for non-ARCompact target.\n")); - return FALSE; + return false; } is_reduced_rf = false; @@ -1847,7 +1847,7 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, { arc_print (_("Error: Couldn't find core register feature in " "supplied target description.")); - return FALSE; + return false; } } } @@ -1882,7 +1882,7 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, arc_print (_("Error: Cannot find required register `%s' in " "feature `%s'.\n"), core_regs[i], core_feature_name); tdesc_data_cleanup (tdesc_data_loc); - return FALSE; + return false; } } @@ -1894,7 +1894,7 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, arc_print (_("Error: Cannot find required feature `%s' in supplied " "target description.\n"), aux_minimal_feature_name); tdesc_data_cleanup (tdesc_data_loc); - return FALSE; + return false; } for (int i = ARC_FIRST_AUX_REGNUM; i <= ARC_LAST_AUX_REGNUM; i++) @@ -1907,14 +1907,14 @@ arc_tdesc_init (struct gdbarch_info info, const struct target_desc **tdesc, "in feature `%s'.\n"), name, tdesc_feature_name (feature)); tdesc_data_cleanup (tdesc_data_loc); - return FALSE; + return false; } } *tdesc = tdesc_loc; *tdesc_data = tdesc_data_loc; - return TRUE; + return true; } /* Implement the type_align gdbarch function. */ -- 2.7.4