From faf6edc026d57b1fbf885f961d6b323fbd255a6a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 12 Oct 2023 17:23:00 +0100 Subject: [PATCH] rtpac3depay: should output audio/x-ac3 not audio/ac3 audio/x-ac3 is the canonical media format in GStreamer. audio/ac3 is sometimes accepted as input (e.g. in rtpac3pay or ac3parse), but shouldn't be output. Fixes #3038. Part-of: --- subprojects/gst-plugins-good/docs/gst_plugins_cache.json | 2 +- subprojects/gst-plugins-good/gst/rtp/gstrtpac3depay.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/subprojects/gst-plugins-good/docs/gst_plugins_cache.json b/subprojects/gst-plugins-good/docs/gst_plugins_cache.json index b2f504d..2f86df8 100644 --- a/subprojects/gst-plugins-good/docs/gst_plugins_cache.json +++ b/subprojects/gst-plugins-good/docs/gst_plugins_cache.json @@ -13721,7 +13721,7 @@ "presence": "always" }, "src": { - "caps": "audio/ac3:\n", + "caps": "audio/x-ac3:\n", "direction": "src", "presence": "always" } diff --git a/subprojects/gst-plugins-good/gst/rtp/gstrtpac3depay.c b/subprojects/gst-plugins-good/gst/rtp/gstrtpac3depay.c index 68c23e2..5bb607b 100644 --- a/subprojects/gst-plugins-good/gst/rtp/gstrtpac3depay.c +++ b/subprojects/gst-plugins-good/gst/rtp/gstrtpac3depay.c @@ -52,7 +52,7 @@ static GstStaticPadTemplate gst_rtp_ac3_depay_src_template = GST_STATIC_PAD_TEMPLATE ("src", GST_PAD_SRC, GST_PAD_ALWAYS, - GST_STATIC_CAPS ("audio/ac3") + GST_STATIC_CAPS ("audio/x-ac3") ); static GstStaticPadTemplate gst_rtp_ac3_depay_sink_template = @@ -120,7 +120,7 @@ gst_rtp_ac3_depay_setcaps (GstRTPBaseDepayload * depayload, GstCaps * caps) clock_rate = 90000; /* default */ depayload->clock_rate = clock_rate; - srccaps = gst_caps_new_empty_simple ("audio/ac3"); + srccaps = gst_caps_new_empty_simple ("audio/x-ac3"); res = gst_pad_set_caps (depayload->srcpad, srccaps); gst_caps_unref (srccaps); -- 2.7.4