From fae3e1133c86af8f03bd1ff2a95d86c652f3e957 Mon Sep 17 00:00:00 2001 From: "James E. Keenan" Date: Sun, 21 Mar 2010 10:52:31 -0400 Subject: [PATCH] Inline comment about difficulties which 'eval qq()' will pose --- dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm index 7028dd7..6798ed4 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm @@ -768,6 +768,14 @@ EOF } elsif ($gotRETVAL || $wantRETVAL) { my $t = $args{optimize} && $targetable{$type_kind{$ret_type}}; + # Although the '$var' declared in the next line is never explicitly + # used within this 'elsif' block, commenting it out leads to + # disaster, starting with the first 'eval qq' inside the 'elsif' block + # below. + # It appears that this is related to the fact that at this point the + # value of $t is a reference to an array whose [2] element includes + # '$var' as a substring: + # <> <(IV)$var> my $var = 'RETVAL'; my $type = $ret_type; -- 2.7.4