From fac416667fed565d3d61b25b6736e39b266e22f0 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Sun, 2 Aug 2009 15:20:22 -0400 Subject: [PATCH] [HB] Add XXX marks --- pango/opentype/hb-ot-layout-private.h | 2 ++ pango/opentype/hb-ot-layout.cc | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pango/opentype/hb-ot-layout-private.h b/pango/opentype/hb-ot-layout-private.h index 48e9145..3fdd428 100644 --- a/pango/opentype/hb-ot-layout-private.h +++ b/pango/opentype/hb-ot-layout-private.h @@ -28,7 +28,9 @@ #define HB_OT_LAYOUT_PRIVATE_H #include "hb-private.h" + #include "hb-ot-layout.h" + #include "hb-buffer-private.h" diff --git a/pango/opentype/hb-ot-layout.cc b/pango/opentype/hb-ot-layout.cc index dd98d74..03f7c56 100644 --- a/pango/opentype/hb-ot-layout.cc +++ b/pango/opentype/hb-ot-layout.cc @@ -28,10 +28,6 @@ #define HB_OT_LAYOUT_CC -/* XXX */ -#include "hb-buffer-private.h" - -#include "hb-ot-layout.h" #include "hb-ot-layout-private.h" #include "hb-ot-layout-open-private.h" @@ -263,7 +259,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t *layout, hb_codepoint_t glyph, hb_ot_layout_glyph_class_t klass) { - /* TODO optimize this, similar to old harfbuzz code for example */ + /* TODO optimize this? similar to old harfbuzz code for example */ hb_ot_layout_class_t gdef_klass; int len = layout->new_gdef.len; @@ -271,6 +267,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t *layout, if (HB_UNLIKELY (glyph > 65535)) return; + /* XXX this is not threadsafe */ if (glyph >= len) { int new_len; unsigned char *new_klasses; -- 2.7.4