From fa8e2d9bfeec654f036995861aabb9b9907fb8e3 Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Tue, 31 Mar 2009 16:42:15 +0300 Subject: [PATCH] goom: the structure is not fully initialized, but the copied. Set to fully to 0 to avoid creep of uninitialized values. --- gst/goom/plugin_info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gst/goom/plugin_info.c b/gst/goom/plugin_info.c index 68e0bf0..6a2411d 100644 --- a/gst/goom/plugin_info.c +++ b/gst/goom/plugin_info.c @@ -109,7 +109,7 @@ void plugin_info_init (PluginInfo * pp, int nbVisuals) { - PluginInfo p; + PluginInfo p = { 0, }; int i; p.sound.speedvar = p.sound.accelvar = p.sound.totalgoom = 0; @@ -147,6 +147,7 @@ plugin_info_init (PluginInfo * pp, int nbVisuals) p.nbVisuals = nbVisuals; p.visuals = (VisualFX **) malloc (sizeof (VisualFX *) * nbVisuals); + /* huh, we're setting a local variable and now copying it over? */ *pp = p; pp->sound.params.params[0] = &pp->sound.biggoom_speed_limit_p; pp->sound.params.params[1] = &pp->sound.biggoom_factor_p; -- 2.7.4