From f9b523ebc367f1535bf61797383471e567b24b75 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 31 May 2023 07:30:14 -0700 Subject: [PATCH] [Analysis] Remove unused class LegacyAARGetter The last use was removed by: commit fa6ea7a419f37befbed04368bcb8af4c718facbb Author: Arthur Eubanks Date: Mon Mar 20 11:18:35 2023 -0700 Once we remove it, createLegacyPMAAResults and createLegacyPMAAResults become unused, so this patch removes them as well. Differential Revision: https://reviews.llvm.org/D151787 --- llvm/include/llvm/Analysis/AliasAnalysis.h | 9 --------- llvm/include/llvm/Analysis/BasicAliasAnalysis.h | 22 ---------------------- llvm/lib/Analysis/AliasAnalysis.cpp | 23 ----------------------- llvm/lib/Analysis/BasicAliasAnalysis.cpp | 7 ------- 4 files changed, 61 deletions(-) diff --git a/llvm/include/llvm/Analysis/AliasAnalysis.h b/llvm/include/llvm/Analysis/AliasAnalysis.h index 737aafc..0b0c4b4 100644 --- a/llvm/include/llvm/Analysis/AliasAnalysis.h +++ b/llvm/include/llvm/Analysis/AliasAnalysis.h @@ -985,15 +985,6 @@ FunctionPass *createAAResultsWrapperPass(); ImmutablePass *createExternalAAWrapperPass( std::function Callback); -/// A helper for the legacy pass manager to create a \c AAResults -/// object populated to the best of our ability for a particular function when -/// inside of a \c ModulePass or a \c CallGraphSCCPass. -/// -/// If a \c ModulePass or a \c CallGraphSCCPass calls \p -/// createLegacyPMAAResults, it also needs to call \p addUsedAAAnalyses in \p -/// getAnalysisUsage. -AAResults createLegacyPMAAResults(Pass &P, Function &F, BasicAAResult &BAR); - } // end namespace llvm #endif // LLVM_ANALYSIS_ALIASANALYSIS_H diff --git a/llvm/include/llvm/Analysis/BasicAliasAnalysis.h b/llvm/include/llvm/Analysis/BasicAliasAnalysis.h index a2735f0..9d76e18 100644 --- a/llvm/include/llvm/Analysis/BasicAliasAnalysis.h +++ b/llvm/include/llvm/Analysis/BasicAliasAnalysis.h @@ -176,28 +176,6 @@ public: FunctionPass *createBasicAAWrapperPass(); -/// A helper for the legacy pass manager to create a \c BasicAAResult object -/// populated to the best of our ability for a particular function when inside -/// of a \c ModulePass or a \c CallGraphSCCPass. -BasicAAResult createLegacyPMBasicAAResult(Pass &P, Function &F); - -/// This class is a functor to be used in legacy module or SCC passes for -/// computing AA results for a function. We store the results in fields so that -/// they live long enough to be queried, but we re-use them each time. -class LegacyAARGetter { - Pass &P; - std::optional BAR; - std::optional AAR; - -public: - LegacyAARGetter(Pass &P) : P(P) {} - AAResults &operator()(Function &F) { - BAR.emplace(createLegacyPMBasicAAResult(P, F)); - AAR.emplace(createLegacyPMAAResults(P, F, *BAR)); - return *AAR; - } -}; - } // end namespace llvm #endif // LLVM_ANALYSIS_BASICALIASANALYSIS_H diff --git a/llvm/lib/Analysis/AliasAnalysis.cpp b/llvm/lib/Analysis/AliasAnalysis.cpp index cf1b116..de61340 100644 --- a/llvm/lib/Analysis/AliasAnalysis.cpp +++ b/llvm/lib/Analysis/AliasAnalysis.cpp @@ -840,29 +840,6 @@ AAManager::Result AAManager::run(Function &F, FunctionAnalysisManager &AM) { return R; } -AAResults llvm::createLegacyPMAAResults(Pass &P, Function &F, - BasicAAResult &BAR) { - AAResults AAR(P.getAnalysis().getTLI(F)); - - // Add in our explicitly constructed BasicAA results. - if (!DisableBasicAA) - AAR.addAAResult(BAR); - - // Populate the results with the other currently available AAs. - if (auto *WrapperPass = - P.getAnalysisIfAvailable()) - AAR.addAAResult(WrapperPass->getResult()); - if (auto *WrapperPass = P.getAnalysisIfAvailable()) - AAR.addAAResult(WrapperPass->getResult()); - if (auto *WrapperPass = P.getAnalysisIfAvailable()) - AAR.addAAResult(WrapperPass->getResult()); - if (auto *WrapperPass = P.getAnalysisIfAvailable()) - if (WrapperPass->CB) - WrapperPass->CB(P, F, AAR); - - return AAR; -} - bool llvm::isNoAliasCall(const Value *V) { if (const auto *Call = dyn_cast(V)) return Call->hasRetAttr(Attribute::NoAlias); diff --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp index f806e37..5093166 100644 --- a/llvm/lib/Analysis/BasicAliasAnalysis.cpp +++ b/llvm/lib/Analysis/BasicAliasAnalysis.cpp @@ -1827,10 +1827,3 @@ void BasicAAWrapperPass::getAnalysisUsage(AnalysisUsage &AU) const { AU.addRequiredTransitive(); AU.addRequiredTransitive(); } - -BasicAAResult llvm::createLegacyPMBasicAAResult(Pass &P, Function &F) { - return BasicAAResult( - F.getParent()->getDataLayout(), F, - P.getAnalysis().getTLI(F), - P.getAnalysis().getAssumptionCache(F)); -} -- 2.7.4