From f900fc9d80d20dbb832c9e1ca82c812bd5fb9976 Mon Sep 17 00:00:00 2001 From: "erik.corry@gmail.com" Date: Tue, 11 Oct 2011 09:28:06 +0000 Subject: [PATCH] Remove some unused and unneeded flags. Review URL: http://codereview.chromium.org/8228004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- benchmarks/spinning-balls/v.js | 22 ++++++++++++++++++++-- src/arm/code-stubs-arm.cc | 4 ---- src/flag-definitions.h | 7 ------- src/ia32/code-stubs-ia32.cc | 4 ---- src/mips/code-stubs-mips.cc | 4 ---- src/spaces.h | 4 ++-- src/x64/code-stubs-x64.cc | 4 ---- 7 files changed, 22 insertions(+), 27 deletions(-) diff --git a/benchmarks/spinning-balls/v.js b/benchmarks/spinning-balls/v.js index 87366d9..056c56d 100644 --- a/benchmarks/spinning-balls/v.js +++ b/benchmarks/spinning-balls/v.js @@ -42,6 +42,9 @@ if ( !window.requestAnimationFrame ) { } )(); } + + + var kNPoints = 8000; var kNModifications = 20; var kNVisiblePoints = 200; @@ -54,10 +57,22 @@ var livePoints = void 0; var dyingPoints = void 0; var scene = void 0; var renderingStartTime = void 0; +var omitFrameDueToVisibilityChange = false; var scene = void 0; var pausePlot = void 0; var splayTree = void 0; +handleVisibilityChange(); + +function handleVisibilityChange() { + console.log("visibility change"); + omitFrameDueToVisibilityChange = true; + document.addEventListener("webkitvisibilitychange", handleVisibilityChange); + document.addEventListener("msvisibilitychange", handleVisibilityChange); + document.addEventListener("mozvisibilitychange", handleVisibilityChange); + document.addEventListener("visibilitychange", handleVisibilityChange); +} + function Point(x, y, z, payload) { this.x = x; @@ -353,9 +368,12 @@ function render() { scene.draw(); var renderingEndTime = Date.now(); - var pause = renderingEndTime - renderingStartTime; - pausePlot.addPause(pause); + if (!omitFrameDueToVisibilityChange) { + var pause = renderingEndTime - renderingStartTime; + pausePlot.addPause(pause); + } renderingStartTime = renderingEndTime; + omitFrameDueToVisibilityChange = false; pausePlot.draw(); diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc index effa608..44923a1 100644 --- a/src/arm/code-stubs-arm.cc +++ b/src/arm/code-stubs-arm.cc @@ -4426,10 +4426,6 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { #ifdef V8_INTERPRETED_REGEXP __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); #else // V8_INTERPRETED_REGEXP - if (!FLAG_regexp_entry_native) { - __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); - return; - } // Stack frame on entry. // sp[0]: last_match_info (expected JSArray) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 3d0d5bb..6c66c0c 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -300,9 +300,6 @@ DEFINE_int(random_seed, 0, DEFINE_bool(canonicalize_object_literal_maps, true, "Canonicalize maps for object literals.") -DEFINE_bool(use_big_map_space, true, - "Use big map space, but don't compact if it grew too big.") - DEFINE_int(max_map_space_pages, MapSpace::kMaxMapPageIndex - 1, "Maximum number of pages in map space which still allows to encode " "forwarding pointers. That's actually a constant, but it's useful " @@ -338,7 +335,6 @@ DEFINE_bool(preemption, false, // Regexp DEFINE_bool(regexp_optimization, true, "generate optimized regexp code") -DEFINE_bool(regexp_entry_native, true, "use native code to enter regexp") // Testing flags test/cctest/test-{flags,api,serialization}.cc DEFINE_bool(testing_bool_flag, true, "testing_bool_flag") @@ -465,9 +461,6 @@ DEFINE_bool(collect_heap_spill_statistics, false, DEFINE_bool(trace_isolates, false, "trace isolate state changes") -DEFINE_bool(trace_live_byte_count, false, - "trace updates to page live byte count") - // VM state DEFINE_bool(log_state_changes, false, "Log state changes.") diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc index 8a3b897..1e886e2 100644 --- a/src/ia32/code-stubs-ia32.cc +++ b/src/ia32/code-stubs-ia32.cc @@ -3384,10 +3384,6 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { #ifdef V8_INTERPRETED_REGEXP __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); #else // V8_INTERPRETED_REGEXP - if (!FLAG_regexp_entry_native) { - __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); - return; - } // Stack frame on entry. // esp[0]: return address diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc index a0c6d50..1fbbcfa 100644 --- a/src/mips/code-stubs-mips.cc +++ b/src/mips/code-stubs-mips.cc @@ -4471,10 +4471,6 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { #ifdef V8_INTERPRETED_REGEXP __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); #else // V8_INTERPRETED_REGEXP - if (!FLAG_regexp_entry_native) { - __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); - return; - } // Stack frame on entry. // sp[0]: last_match_info (expected JSArray) diff --git a/src/spaces.h b/src/spaces.h index 6149334..ce8e382 100644 --- a/src/spaces.h +++ b/src/spaces.h @@ -452,7 +452,7 @@ class MemoryChunk { // Manage live byte count (count of bytes known to be live, // because they are marked black). void ResetLiveBytes() { - if (FLAG_trace_live_byte_count) { + if (FLAG_gc_verbose) { PrintF("ResetLiveBytes:%p:%x->0\n", static_cast(this), live_byte_count_); } @@ -460,7 +460,7 @@ class MemoryChunk { } void IncrementLiveBytes(int by) { ASSERT_LE(static_cast(live_byte_count_), size_); - if (FLAG_trace_live_byte_count) { + if (FLAG_gc_verbose) { printf("UpdateLiveBytes:%p:%x%c=%x->%x\n", static_cast(this), live_byte_count_, ((by < 0) ? '-' : '+'), ((by < 0) ? -by : by), diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc index 5250f47..7d41ffe 100644 --- a/src/x64/code-stubs-x64.cc +++ b/src/x64/code-stubs-x64.cc @@ -2438,10 +2438,6 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { #ifdef V8_INTERPRETED_REGEXP __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); #else // V8_INTERPRETED_REGEXP - if (!FLAG_regexp_entry_native) { - __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); - return; - } // Stack frame on entry. // rsp[0]: return address -- 2.7.4