From f9008a3a06b7266fc14dce2506e9d5fa6b1f0f0d Mon Sep 17 00:00:00 2001 From: Kostya Kortchinsky Date: Wed, 25 Oct 2017 22:00:26 +0000 Subject: [PATCH] [scudo] Remove comment about security of the 32-bit allocator Summary: The 32-bit allocator is now on par with the 64-bit in terms of security (chunks randomization is done, batches separation is done). Unless objection, the comment can go away. Reviewers: alekseyshl Reviewed By: alekseyshl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D39303 llvm-svn: 316620 --- compiler-rt/lib/scudo/scudo_allocator.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/compiler-rt/lib/scudo/scudo_allocator.h b/compiler-rt/lib/scudo/scudo_allocator.h index 2f317d2..a517058 100644 --- a/compiler-rt/lib/scudo/scudo_allocator.h +++ b/compiler-rt/lib/scudo/scudo_allocator.h @@ -77,9 +77,6 @@ struct AP64 { }; typedef SizeClassAllocator64 PrimaryAllocator; #else -// Currently, the 32-bit Sanitizer allocator has not yet benefited from all the -// security improvements brought to the 64-bit one. This makes the 32-bit -// version of Scudo slightly less toughened. static const uptr NumRegions = SANITIZER_MMAP_RANGE_SIZE >> RegionSizeLog; # if SANITIZER_WORDSIZE == 32 typedef FlatByteMap ByteMap; -- 2.7.4