From f8a8b465e080faf5479c0b38dc67cc9b9ae24927 Mon Sep 17 00:00:00 2001 From: Jamey Sharp Date: Wed, 22 Feb 2006 23:38:16 -0800 Subject: [PATCH] Bugfix: move request_written update *before* _xcb_conn_wait in _xcb_out_flush. Otherwise a reply may be read before we record that we have sent the request, and then XCB gets... confused. --- src/xcb_out.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xcb_out.c b/src/xcb_out.c index 80d7108..0afabc2 100644 --- a/src/xcb_out.c +++ b/src/xcb_out.c @@ -269,9 +269,9 @@ int _xcb_out_write_block(XCBConnection *c, struct iovec *vector, size_t count) int _xcb_out_flush(XCBConnection *c) { int ret = 1; + c->out.request_written = c->out.request; while(ret > 0 && (c->out.queue_len || c->out.vec_len)) ret = _xcb_conn_wait(c, /*should_write*/ 1, &c->out.cond); - c->out.request_written = c->out.request; pthread_cond_broadcast(&c->out.cond); return ret; } -- 2.7.4