From f87473fe1c2a94bce0f84b54715508157c8f5bee Mon Sep 17 00:00:00 2001 From: Volkan Keles Date: Thu, 25 Oct 2018 17:37:07 +0000 Subject: [PATCH] [GISel] LegalizerInfo: Rename MemDesc::Size to SizeInBits to make the value clearer Requested in D53679. llvm-svn: 345288 --- llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h | 2 +- llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp | 4 ++-- llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp | 2 +- llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h b/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h index a8c2608..e0ea575 100644 --- a/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h +++ b/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h @@ -121,7 +121,7 @@ struct LegalityQuery { ArrayRef Types; struct MemDesc { - uint64_t Size; + uint64_t SizeInBits; AtomicOrdering Ordering; }; diff --git a/llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp b/llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp index 344f573..94eab9a 100644 --- a/llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp +++ b/llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp @@ -45,7 +45,7 @@ LegalityPredicate LegalityPredicates::typePairAndMemSizeInSet( SmallVector TypesAndMemSize = TypesAndMemSizeInit; return [=](const LegalityQuery &Query) { TypePairAndMemSize Match = {Query.Types[TypeIdx0], Query.Types[TypeIdx1], - Query.MMODescrs[MMOIdx].Size}; + Query.MMODescrs[MMOIdx].SizeInBits}; return std::find(TypesAndMemSize.begin(), TypesAndMemSize.end(), Match) != TypesAndMemSize.end(); }; @@ -82,7 +82,7 @@ LegalityPredicate LegalityPredicates::sizeNotPow2(unsigned TypeIdx) { LegalityPredicate LegalityPredicates::memSizeInBytesNotPow2(unsigned MMOIdx) { return [=](const LegalityQuery &Query) { - return !isPowerOf2_32(Query.MMODescrs[MMOIdx].Size /* In Bytes */); + return !isPowerOf2_32(Query.MMODescrs[MMOIdx].SizeInBits / 8); }; } diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp index 1bfede0..b6ed265 100644 --- a/llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp +++ b/llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp @@ -51,7 +51,7 @@ raw_ostream &LegalityQuery::print(raw_ostream &OS) const { OS << Opcode << ", MMOs={"; for (const auto &MMODescr : MMODescrs) { - OS << MMODescr.Size << ", "; + OS << MMODescr.SizeInBits << ", "; } OS << "}"; diff --git a/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp b/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp index f0648f0..474516f 100644 --- a/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp +++ b/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp @@ -167,7 +167,7 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST) { .unsupportedIfMemSizeNotPow2() // Lower any any-extending loads left into G_ANYEXT and G_LOAD .lowerIf([=](const LegalityQuery &Query) { - return Query.Types[0].getSizeInBits() != Query.MMODescrs[0].Size; + return Query.Types[0].getSizeInBits() != Query.MMODescrs[0].SizeInBits; }) .clampNumElements(0, v2s32, v2s32); @@ -185,7 +185,7 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST) { .unsupportedIfMemSizeNotPow2() .lowerIf([=](const LegalityQuery &Query) { return Query.Types[0].isScalar() && - Query.Types[0].getSizeInBits() != Query.MMODescrs[0].Size; + Query.Types[0].getSizeInBits() != Query.MMODescrs[0].SizeInBits; }) .clampNumElements(0, v2s32, v2s32); -- 2.7.4