From f84d01bb3f0b147f40f78bfc8a1ccf3c02690c3a Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Mon, 2 Dec 2019 18:13:28 +0100 Subject: [PATCH] Re-enable CoreLib analyzers (#424) * Re-enable CoreLib analyzers CoreLib analyzers were unintentionally disabled with 6afe96cc2e950379d13a87efa1fa5a651cbce9bd. This re-enables the analyzers. * Remove Microsoft.CodeAnalysis.Common from common Microsoft.CodeAnalysis.Common shouldn't be referenced directly, therefore removing that package from the common location and only restoring and marking it as an analyzer in the libraries restore phase. --- eng/Analyzers.props | 7 +++---- .../src/System.Private.CoreLib/System.Private.CoreLib.csproj | 2 +- src/libraries/restore/analyzers/analyzers.depproj | 8 ++++++++ 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/eng/Analyzers.props b/eng/Analyzers.props index 24d83dc..e2163a7 100644 --- a/eng/Analyzers.props +++ b/eng/Analyzers.props @@ -3,9 +3,8 @@ $(MSBuildThisFileDirectory)CodeAnalysis.ruleset - - - - + + + diff --git a/src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj b/src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj index 307f884..58b4d5f 100644 --- a/src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj +++ b/src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj @@ -63,7 +63,7 @@ <_FullFrameworkReferenceAssemblyPaths>$(MSBuildThisFileDirectory)/Documentation true $(OutputPath)$(MSBuildProjectName).xml - false + true diff --git a/src/libraries/restore/analyzers/analyzers.depproj b/src/libraries/restore/analyzers/analyzers.depproj index 75547d7..93e179e 100644 --- a/src/libraries/restore/analyzers/analyzers.depproj +++ b/src/libraries/restore/analyzers/analyzers.depproj @@ -5,6 +5,14 @@ C# + + + + +