From f8326b605245e10438ceaa8da23109e3fa077482 Mon Sep 17 00:00:00 2001 From: Hal Finkel Date: Mon, 12 Nov 2012 19:41:38 +0000 Subject: [PATCH] BBVectorize: Check the types of compare instructions The pass would previously assert when trying to compute the cost of compare instructions with illegal vector types (like struct pointers). llvm-svn: 167743 --- llvm/lib/Transforms/Vectorize/BBVectorize.cpp | 2 ++ llvm/test/Transforms/BBVectorize/X86/cmp-types.ll | 16 ++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 llvm/test/Transforms/BBVectorize/X86/cmp-types.ll diff --git a/llvm/lib/Transforms/Vectorize/BBVectorize.cpp b/llvm/lib/Transforms/Vectorize/BBVectorize.cpp index 93cd27e..407cd7b 100644 --- a/llvm/lib/Transforms/Vectorize/BBVectorize.cpp +++ b/llvm/lib/Transforms/Vectorize/BBVectorize.cpp @@ -485,6 +485,8 @@ namespace { T2 = SI->getCondition()->getType(); } else if (ShuffleVectorInst *SI = dyn_cast(I)) { T2 = SI->getOperand(0)->getType(); + } else if (CmpInst *CI = dyn_cast(I)) { + T2 = CI->getOperand(0)->getType(); } } diff --git a/llvm/test/Transforms/BBVectorize/X86/cmp-types.ll b/llvm/test/Transforms/BBVectorize/X86/cmp-types.ll new file mode 100644 index 0000000..a4fcbb6 --- /dev/null +++ b/llvm/test/Transforms/BBVectorize/X86/cmp-types.ll @@ -0,0 +1,16 @@ +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" +; RUN: opt < %s -mtriple=x86_64-unknown-linux-gnu -mcpu=corei7 -bb-vectorize -S | FileCheck %s + +%"struct.btSoftBody" = type { float, float, float*, i8 } + +define void @test1(%"struct.btSoftBody"* %n1, %"struct.btSoftBody"* %n2) uwtable align 2 { +entry: + %tobool15 = icmp ne %"struct.btSoftBody"* %n1, null + %cond16 = zext i1 %tobool15 to i32 + %tobool21 = icmp ne %"struct.btSoftBody"* %n2, null + %cond22 = zext i1 %tobool21 to i32 + ret void +; CHECK: @test1 +} + -- 2.7.4