From f816578e4e251802d057d0edca016629edd5a2ac Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sun, 20 Aug 2023 17:31:06 -0700 Subject: [PATCH] nv50: Remove unused value Fix defect reported by Coverity Scan. Unused value (UNUSED_VALUE) assigned_pointer: Assigning value from &nv50->vtxbuf[b] to vb here, but that stored value is overwritten before it can be used. Fixes: 76725452239 ("gallium: move vertex stride to CSO") Signed-off-by: Vinson Lee Reviewed-By: Mike Blumenkrantz Reviewed-by: Karol Herbst Part-of: --- src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_vbo.c b/src/gallium/drivers/nouveau/nv50/nv50_vbo.c index 1ad72f0..0da8316 100644 --- a/src/gallium/drivers/nouveau/nv50/nv50_vbo.c +++ b/src/gallium/drivers/nouveau/nv50/nv50_vbo.c @@ -294,7 +294,6 @@ nv50_vertex_arrays_validate(struct nv50_context *nv50) uint32_t limits[PIPE_MAX_ATTRIBS]; struct nouveau_pushbuf *push = nv50->base.pushbuf; struct nv50_vertex_stateobj *vertex = nv50->vertex; - struct pipe_vertex_buffer *vb; struct nv50_vertex_element *ve; uint32_t mask; uint32_t refd = 0; @@ -341,7 +340,6 @@ nv50_vertex_arrays_validate(struct nv50_context *nv50) assert(b < PIPE_MAX_ATTRIBS); ve = &vertex->element[i]; - vb = &nv50->vtxbuf[b]; if (likely(vertex->strides[b]) || !(nv50->vbo_user & (1 << b))) PUSH_DATA(push, ve->state); @@ -368,6 +366,7 @@ nv50_vertex_arrays_validate(struct nv50_context *nv50) for (i = 0; i < vertex->num_elements; ++i) { uint64_t address, limit; const unsigned b = vertex->element[i].pipe.vertex_buffer_index; + struct pipe_vertex_buffer *vb; assert(b < PIPE_MAX_ATTRIBS); ve = &vertex->element[i]; -- 2.7.4