From f785bb354dcca417ae45dd4f0aae1746dba3d8f8 Mon Sep 17 00:00:00 2001 From: Dongjin Choi Date: Mon, 16 Sep 2013 21:52:34 +0900 Subject: [PATCH] Update change log and spec for wrt-plugins-tizen_0.4.68 [model] REDWOOD [binary_type] PDA [customer] OPEN [Systeminfo] rollback 281623 [Issue#] N/A [Problem] Unchecked return value. [Cause] calling function notification_set_execute_option without checking return value. [Solution] Inserted checking return value. [team] WebAPI [request] N/A [horizontal_expansion] N/A UnitTC passed. --- packaging/wrt-plugins-tizen.spec | 2 +- src/Notification/NotificationManager.cpp | 10 ++++++++-- src/Systeminfo/EventWatchSysteminfo.cpp | 1 - 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/packaging/wrt-plugins-tizen.spec b/packaging/wrt-plugins-tizen.spec index da710f1..af2a5e5 100755 --- a/packaging/wrt-plugins-tizen.spec +++ b/packaging/wrt-plugins-tizen.spec @@ -1,6 +1,6 @@ Name: wrt-plugins-tizen Summary: JavaScript plugins for WebRuntime -Version: 0.4.67 +Version: 0.4.68 Release: 0 Group: Development/Libraries License: Apache License, Version 2.0 diff --git a/src/Notification/NotificationManager.cpp b/src/Notification/NotificationManager.cpp index c822a2b..e0a4073 100755 --- a/src/Notification/NotificationManager.cpp +++ b/src/Notification/NotificationManager.cpp @@ -137,7 +137,10 @@ int NotificationManager::post(StatusNotification *notification) { LoggerI("Notification Launch Flag True"); notification_set_property(handle, 0); - notification_set_execute_option(handle, NOTIFICATION_EXECUTE_TYPE_SINGLE_LAUNCH, NULL, NULL, service_data); + if (notification_set_execute_option(handle, NOTIFICATION_EXECUTE_TYPE_SINGLE_LAUNCH, NULL, NULL, service_data) != SERVICE_ERROR_NONE) + { + LoggerD("can't set notification option"); + } } } else @@ -330,7 +333,10 @@ void NotificationManager::update(StatusNotification *notification) { LoggerI("Notification Launch Flag True"); notification_set_property(handle, 0); - notification_set_execute_option(handle, NOTIFICATION_EXECUTE_TYPE_SINGLE_LAUNCH, NULL, NULL, service_data); + if (notification_set_execute_option(handle, NOTIFICATION_EXECUTE_TYPE_SINGLE_LAUNCH, NULL, NULL, service_data)!= SERVICE_ERROR_NONE) + { + LoggerI("Can't set Service option"); + } } else { diff --git a/src/Systeminfo/EventWatchSysteminfo.cpp b/src/Systeminfo/EventWatchSysteminfo.cpp index 66e2051..1da11d0 100755 --- a/src/Systeminfo/EventWatchSysteminfo.cpp +++ b/src/Systeminfo/EventWatchSysteminfo.cpp @@ -201,7 +201,6 @@ void EventWatchSysteminfo::processGetValue() break; } m_setLastValue = true; - m_cbm->callOnSuccess(lastValue); return; } -- 2.7.4