From f78469763f3f5d11ff87e9bf38b99d9f860a1723 Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Tue, 9 Aug 2011 16:13:42 -0700 Subject: [PATCH] Keep verbatim pod in ExtUtils::Typemaps within 80 cols --- dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm | 18 +++++++++++++----- t/porting/known_pod_issues.dat | 1 - 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm index 0f5d12c..7ecc777 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm @@ -2,7 +2,7 @@ package ExtUtils::Typemaps; use 5.006001; use strict; use warnings; -our $VERSION = '1.00'; +our $VERSION = '1.01'; #use Carp qw(croak); require ExtUtils::ParseXS; @@ -26,9 +26,14 @@ ExtUtils::Typemaps - Read/Write/Modify Perl/XS typemap files # add a mapping $typemap->add_typemap(ctype => 'NV', xstype => 'T_NV'); - $typemap->add_inputmap (xstype => 'T_NV', code => '$var = ($type)SvNV($arg);'); - $typemap->add_outputmap(xstype => 'T_NV', code => 'sv_setnv($arg, (NV)$var);'); - $typemap->add_string(string => $typemapstring); # will be parsed and merged + $typemap->add_inputmap( + xstype => 'T_NV', code => '$var = ($type)SvNV($arg);' + ); + $typemap->add_outputmap( + xstype => 'T_NV', code => 'sv_setnv($arg, (NV)$var);' + ); + $typemap->add_string(string => $typemapstring); + # will be parsed and merged # remove a mapping (same for remove_typemap and remove_outputmap...) $typemap->remove_inputmap(xstype => 'SomeType'); @@ -732,7 +737,10 @@ corresponding OUTPUT code: 'T_OUT' => ' { GV *gv = newGVgen("$Package"); if ( do_open(gv, "+>&", 3, FALSE, 0, 0, $var) ) - sv_setsv($arg, sv_bless(newRV((SV*)gv), gv_stashpv("$Package",1))); + sv_setsv( + $arg, + sv_bless(newRV((SV*)gv), gv_stashpv("$Package",1)) + ); else $arg = &PL_sv_undef; } diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat index d508354..db818ee 100644 --- a/t/porting/known_pod_issues.dat +++ b/t/porting/known_pod_issues.dat @@ -137,7 +137,6 @@ dist/bignum/lib/bignum.pm Apparent broken link 1 dist/bignum/lib/bigrat.pm Apparent broken link 1 dist/constant/lib/constant.pm Apparent broken link 2 dist/data-dumper/dumper.pm ? Should you be using L<...> instead of 1 -dist/extutils-parsexs/lib/extutils/typemaps.pm Verbatim line length including indents exceeds 80 by 4 dist/extutils-parsexs/lib/extutils/typemaps/outputmap.pm Verbatim line length including indents exceeds 80 by 1 dist/extutils-parsexs/lib/perlxs.pod Verbatim line length including indents exceeds 80 by 4 dist/extutils-parsexs/lib/perlxstut.pod Verbatim line length including indents exceeds 80 by 9 -- 2.7.4