From f7223cfdab653409cd92d117c906de166b00623b Mon Sep 17 00:00:00 2001 From: Robert Krakora Date: Tue, 16 Aug 2011 12:09:48 +0200 Subject: [PATCH] client: destroy pipeline on client disconnect with no prior TEARDOWN. The problem occurs when the client abruptly closes the connection without issuing a TEARDOWN. The TEARDOWN handler in the rtsp-client.c file of the RTSP server is where the pipeline gets torn down. Since this handler is not called, the pipeline remains and is up and running. Subsequent clients get their own pipelines and if the do not issue TEARDOWNs then those pipelines will also remain up and running. This is a resource leak. --- gst/rtsp-server/rtsp-client.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gst/rtsp-server/rtsp-client.c b/gst/rtsp-server/rtsp-client.c index 6a5bc76..ec91752 100644 --- a/gst/rtsp-server/rtsp-client.c +++ b/gst/rtsp-server/rtsp-client.c @@ -121,8 +121,12 @@ client_unlink_session (GstRTSPClient * client, GstRTSPSession * session) /* unlink all media managed in this session */ for (medias = session->medias; medias; medias = g_list_next (medias)) { - unlink_session_streams (client, session, - (GstRTSPSessionMedia *) medias->data); + GstRTSPSessionMedia *media = medias->data; + + gst_rtsp_session_media_set_state (media, GST_STATE_NULL); + unlink_session_streams (client, session, media); + /* unmanage the media in the session. */ + gst_rtsp_session_release_media (session, media); } } -- 2.7.4