From f715fa5cd88f73c55286fb5eeb991daecef57818 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Tue, 6 Jun 2023 15:59:26 -0700 Subject: [PATCH] Revert "Reland [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD" This reverts commit fffa05a2bcb548d5189e8c2e52d2ed2e7ebb2498. This seems to cause hwasan tests to run in environments it didn't run in before. --- compiler-rt/CMakeLists.txt | 8 +++++++- compiler-rt/test/hwasan/TestCases/sizes.cpp | 2 -- llvm/runtimes/CMakeLists.txt | 9 --------- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/compiler-rt/CMakeLists.txt b/compiler-rt/CMakeLists.txt index 80954df..6489aa1 100644 --- a/compiler-rt/CMakeLists.txt +++ b/compiler-rt/CMakeLists.txt @@ -738,8 +738,14 @@ if(COMPILER_RT_USE_LIBCXX) endif() endif() -if(COMPILER_RT_HAS_TRUNK_LLD AND LLVM_USE_LINKER STREQUAL "lld") +set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/tools/lld) +if(EXISTS ${COMPILER_RT_LLD_PATH}/ AND LLVM_TOOL_LLD_BUILD) set(COMPILER_RT_HAS_LLD TRUE) +else() + set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/../lld) + if(EXISTS ${COMPILER_RT_LLD_PATH}/ AND LLVM_TOOL_LLD_BUILD) + set(COMPILER_RT_HAS_LLD TRUE) + endif() endif() if(ANDROID) diff --git a/compiler-rt/test/hwasan/TestCases/sizes.cpp b/compiler-rt/test/hwasan/TestCases/sizes.cpp index e3cc582..2cb70f5 100644 --- a/compiler-rt/test/hwasan/TestCases/sizes.cpp +++ b/compiler-rt/test/hwasan/TestCases/sizes.cpp @@ -19,8 +19,6 @@ // RUN: %env_hwasan_opts=allocator_may_return_null=1 %run %t new-nothrow max 2>&1 // RUN: %run %t usable 2>&1 -// REQUIRES: android - // Tests for various edge cases related to sizes, notably the maximum size the // allocator can allocate. Tests that an integer overflow in the parameters of // calloc is caught. diff --git a/llvm/runtimes/CMakeLists.txt b/llvm/runtimes/CMakeLists.txt index 4f2c1a1..75256c1 100644 --- a/llvm/runtimes/CMakeLists.txt +++ b/llvm/runtimes/CMakeLists.txt @@ -226,10 +226,6 @@ function(runtime_default_target) set_enable_per_target_runtime_dir() - if ("lld" IN_LIST LLVM_ENABLE_PROJECTS) - list(APPEND extra_args -DCOMPILER_RT_HAS_TRUNK_LLD=TRUE) - endif() - llvm_ExternalProject_Add(runtimes ${CMAKE_CURRENT_SOURCE_DIR}/../../runtimes DEPENDS ${ARG_DEPENDS} @@ -246,7 +242,6 @@ function(runtime_default_target) ${COMMON_CMAKE_ARGS} ${RUNTIMES_CMAKE_ARGS} ${ARG_CMAKE_ARGS} - ${extra_args} PASSTHROUGH_PREFIXES LLVM_ENABLE_RUNTIMES LLVM_USE_LINKER ${ARG_PREFIXES} @@ -339,10 +334,6 @@ function(runtime_register_target name) set_enable_per_target_runtime_dir() - if ("lld" IN_LIST LLVM_ENABLE_PROJECTS) - list(APPEND ${name}_extra_args -DCOMPILER_RT_HAS_TRUNK_LLD=TRUE) - endif() - llvm_ExternalProject_Add(runtimes-${name} ${CMAKE_CURRENT_SOURCE_DIR}/../../runtimes DEPENDS ${ARG_DEPENDS} -- 2.7.4