From f6fa95b77f33c3690e4201e505cb8dce1433abd9 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Wed, 6 Oct 2021 14:30:31 +0100 Subject: [PATCH] [Support] ErrorHandling.h - Remove report_fatal_error(std::string) As described on D111049, removing the dependency from error handling removes considerable build overhead, its recommended that the report_fatal_error(Twine) variant is used instead. --- llvm/include/llvm/Support/ErrorHandling.h | 4 +--- llvm/lib/Support/ErrorHandling.cpp | 4 ---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/llvm/include/llvm/Support/ErrorHandling.h b/llvm/include/llvm/Support/ErrorHandling.h index 260c76f..f980510 100644 --- a/llvm/include/llvm/Support/ErrorHandling.h +++ b/llvm/include/llvm/Support/ErrorHandling.h @@ -15,7 +15,6 @@ #define LLVM_SUPPORT_ERRORHANDLING_H #include "llvm/Support/Compiler.h" -#include namespace llvm { class StringRef; @@ -68,10 +67,9 @@ namespace llvm { /// standard error, followed by a newline. /// After the error handler is called this function will call abort(), it /// does not return. +/// NOTE: The std::string variant was removed to avoid a dependency. [[noreturn]] void report_fatal_error(const char *reason, bool gen_crash_diag = true); -[[noreturn]] void report_fatal_error(const std::string &reason, - bool gen_crash_diag = true); [[noreturn]] void report_fatal_error(StringRef reason, bool gen_crash_diag = true); [[noreturn]] void report_fatal_error(const Twine &reason, diff --git a/llvm/lib/Support/ErrorHandling.cpp b/llvm/lib/Support/ErrorHandling.cpp index b15c36f..433417a 100644 --- a/llvm/lib/Support/ErrorHandling.cpp +++ b/llvm/lib/Support/ErrorHandling.cpp @@ -83,10 +83,6 @@ void llvm::report_fatal_error(const char *Reason, bool GenCrashDiag) { report_fatal_error(Twine(Reason), GenCrashDiag); } -void llvm::report_fatal_error(const std::string &Reason, bool GenCrashDiag) { - report_fatal_error(Twine(Reason), GenCrashDiag); -} - void llvm::report_fatal_error(StringRef Reason, bool GenCrashDiag) { report_fatal_error(Twine(Reason), GenCrashDiag); } -- 2.7.4