From f6da1bc3eea337f3c8ae70b3e9a05b8188199fab Mon Sep 17 00:00:00 2001 From: Sangchul Lee Date: Thu, 16 Apr 2020 15:51:57 +0900 Subject: [PATCH] Remove useless condition in __ms_signal_destroy() The first parameter of GST_IS_ELEMENT() macro is nullable by looking inside of it. If null is set, it will return false. Change-Id: I83bcdeccfd24623649de73ea159427dd3f93ba24 Signed-off-by: Sangchul Lee --- src/media_streamer_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/media_streamer_util.c b/src/media_streamer_util.c index 5208632..8428b95 100644 --- a/src/media_streamer_util.c +++ b/src/media_streamer_util.c @@ -318,7 +318,7 @@ void __ms_signal_destroy(void *data) ms_retm_if(!sig_data, "Empty signal data!"); - if (sig_data->obj && GST_IS_ELEMENT(sig_data->obj)) { + if (GST_IS_ELEMENT(sig_data->obj)) { if (g_signal_handler_is_connected(sig_data->obj, sig_data->signal_id)) { g_signal_handler_disconnect(sig_data->obj, sig_data->signal_id); ms_debug("Signal with id[%lu] disconnected from object [%s].", sig_data->signal_id, GST_OBJECT_NAME(sig_data->obj)); -- 2.7.4