From f6bcbf3d88c5af10cc40c7cd031cc53a3b1cad36 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Sat, 14 Jul 2018 00:10:42 +0000 Subject: [PATCH] [llvm-mca] Remove unused InstRef formal from pre and post execute callbacks. NFC. llvm-svn: 337077 --- llvm/tools/llvm-mca/FetchStage.cpp | 2 +- llvm/tools/llvm-mca/FetchStage.h | 2 +- llvm/tools/llvm-mca/Pipeline.cpp | 12 ++++++------ llvm/tools/llvm-mca/Pipeline.h | 4 ++-- llvm/tools/llvm-mca/Stage.h | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/llvm/tools/llvm-mca/FetchStage.cpp b/llvm/tools/llvm-mca/FetchStage.cpp index 654f177..3da117c 100644 --- a/llvm/tools/llvm-mca/FetchStage.cpp +++ b/llvm/tools/llvm-mca/FetchStage.cpp @@ -29,7 +29,7 @@ bool FetchStage::execute(InstRef &IR) { return true; } -void FetchStage::postExecute(const InstRef &IR) { SM.updateNext(); } +void FetchStage::postExecute() { SM.updateNext(); } void FetchStage::cycleEnd() { // Find the first instruction which hasn't been retired. diff --git a/llvm/tools/llvm-mca/FetchStage.h b/llvm/tools/llvm-mca/FetchStage.h index c824b32..620075d 100644 --- a/llvm/tools/llvm-mca/FetchStage.h +++ b/llvm/tools/llvm-mca/FetchStage.h @@ -36,7 +36,7 @@ public: bool hasWorkToComplete() const override final; bool execute(InstRef &IR) override final; - void postExecute(const InstRef &IR) override final; + void postExecute() override final; void cycleEnd() override final; }; diff --git a/llvm/tools/llvm-mca/Pipeline.cpp b/llvm/tools/llvm-mca/Pipeline.cpp index eb95b0c..7c937e7 100644 --- a/llvm/tools/llvm-mca/Pipeline.cpp +++ b/llvm/tools/llvm-mca/Pipeline.cpp @@ -47,14 +47,14 @@ bool Pipeline::executeStages(InstRef &IR) { return true; } -void Pipeline::preExecuteStages(const InstRef &IR) { +void Pipeline::preExecuteStages() { for (const std::unique_ptr &S : Stages) - S->preExecute(IR); + S->preExecute(); } -void Pipeline::postExecuteStages(const InstRef &IR) { +void Pipeline::postExecuteStages() { for (const std::unique_ptr &S : Stages) - S->postExecute(IR); + S->postExecute(); } void Pipeline::run() { @@ -75,10 +75,10 @@ void Pipeline::runCycle() { // Continue executing this cycle until any stage claims it cannot make // progress. while (true) { - preExecuteStages(IR); + preExecuteStages(); if (!executeStages(IR)) break; - postExecuteStages(IR); + postExecuteStages(); } for (auto &S : Stages) diff --git a/llvm/tools/llvm-mca/Pipeline.h b/llvm/tools/llvm-mca/Pipeline.h index 6bafc24..6916e42 100644 --- a/llvm/tools/llvm-mca/Pipeline.h +++ b/llvm/tools/llvm-mca/Pipeline.h @@ -59,9 +59,9 @@ class Pipeline { std::set Listeners; unsigned Cycles; - void preExecuteStages(const InstRef &IR); + void preExecuteStages(); bool executeStages(InstRef &IR); - void postExecuteStages(const InstRef &IR); + void postExecuteStages(); void runCycle(); bool hasWorkToProcess(); diff --git a/llvm/tools/llvm-mca/Stage.h b/llvm/tools/llvm-mca/Stage.h index 2821662..9dbdcd8 100644 --- a/llvm/tools/llvm-mca/Stage.h +++ b/llvm/tools/llvm-mca/Stage.h @@ -50,12 +50,12 @@ public: /// Called prior to executing the list of stages. /// This can be called multiple times per cycle. - virtual void preExecute(const InstRef &IR) {} + virtual void preExecute() {} /// Called as a cleanup and finalization phase after each execution. /// This will only be called if all stages return a success from their /// execute callback. This can be called multiple times per cycle. - virtual void postExecute(const InstRef &IR) {} + virtual void postExecute() {} /// The primary action that this stage performs. /// Returning false prevents successor stages from having their 'execute' -- 2.7.4