From f6ba5c4d5f228366a016534e7d1cf099d274fced Mon Sep 17 00:00:00 2001 From: Frederic Cambus Date: Mon, 20 Dec 2021 16:22:01 +0100 Subject: [PATCH] [llvm-readobj] Check ELFType value first when checking for OpenBSD notes. Checking ELFType == ELF::ET_CORE first skips string comparison for the majority of cases. Suggested by Fangrui Song in D114635 for a similar construct. --- llvm/tools/llvm-readobj/ELFDumper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp index 2f64b07..9d9c222 100644 --- a/llvm/tools/llvm-readobj/ELFDumper.cpp +++ b/llvm/tools/llvm-readobj/ELFDumper.cpp @@ -5492,7 +5492,7 @@ StringRef getNoteTypeName(const typename ELFT::Note &Note, unsigned ELFType) { return Result; return FindNote(CoreNoteTypes); } - if (Name.startswith("OpenBSD") && ELFType == ELF::ET_CORE) { + if (ELFType == ELF::ET_CORE && Name.startswith("OpenBSD")) { // OpenBSD also places the generic core notes in the OpenBSD namespace. StringRef Result = FindNote(OpenBSDCoreNoteTypes); if (!Result.empty()) -- 2.7.4