From f66bc0e0beeff7fa27c29f740d2f314d63b3346d Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Thu, 21 Sep 2017 19:03:06 +0200 Subject: [PATCH] GPT: incomplete initialization in allocate_disk_part memset(newpart, '\0', sizeof(newpart)); only initializes the firest 4 or 8 bytes of *newpart and not the whole structure disk_part. We should use sizeof(struct disk_part). Instead of malloc and memset we can use calloc. Identified by cppcheck. Fixes: 09a49930e41 GPT: read partition table from device into a data structure Reported-by: Coverity (CID: 167228) Cc: Stefan Roese Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese Reviewed-by: Simon Glass --- cmd/gpt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/gpt.c b/cmd/gpt.c index 638aa19..d4406e3 100644 --- a/cmd/gpt.c +++ b/cmd/gpt.c @@ -190,10 +190,9 @@ static void del_gpt_info(void) static struct disk_part *allocate_disk_part(disk_partition_t *info, int partnum) { struct disk_part *newpart; - newpart = malloc(sizeof(*newpart)); + newpart = calloc(1, sizeof(struct disk_part)); if (!newpart) return ERR_PTR(-ENOMEM); - memset(newpart, '\0', sizeof(newpart)); newpart->gpt_part_info.start = info->start; newpart->gpt_part_info.size = info->size; -- 2.7.4