From f627dd4da804c00b5e89e5e2c488c2bad6205262 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 27 Feb 2019 13:58:56 +0000 Subject: [PATCH] Fix -Wempty-body warnings in Hurd-specific code. This patch fixes -Wempty-body warnings in Hurd-specific code that show up building glibc with -Wextra. Note: there also such warnings on many platforms arising from the default definition of HP_TIMING_NOW in sysdeps/generic/hp-timing.h, but no change there is proposed in this patch because of other changes under discussion in that area that would result in a nonempty definition. Tested with build-many-glibcs.py. * hurd/hurdinit.c (_hurd_init): Use braces around empty body of an if statement. --- ChangeLog | 3 +++ hurd/hurdinit.c | 10 ++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 34e4558..de34cdd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2019-02-27 Joseph Myers + * hurd/hurdinit.c (_hurd_init): Use braces around empty body of an + if statement. + * benchtests/bench-strcpy.c (do_test): Use space before '('. * benchtests/bench-string.h (cmdline_process_function): Likewise. * benchtests/bench-strlen.c (do_test): Likewise. diff --git a/hurd/hurdinit.c b/hurd/hurdinit.c index f4a3607..938e6da 100644 --- a/hurd/hurdinit.c +++ b/hurd/hurdinit.c @@ -100,10 +100,12 @@ _hurd_init (int flags, char **argv, portarraysize * sizeof (mach_port_t)); if (flags & EXEC_SECURE) - /* XXX if secure exec, elide environment variables - which the library uses and could be security holes. - CORESERVER, COREFILE - */ ; + { + /* XXX if secure exec, elide environment variables + which the library uses and could be security holes. + CORESERVER, COREFILE + */ + } /* Call other things which want to do some initialization. These are not on the __libc_subinit hook because things there like to be able to -- 2.7.4